linux-kernel - Re: [PATCH v5] arm64: dts: qcom: lemans-evk: Add OTG support for primary USB controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ea7b151d-7b32-4ebd-b3e0-3fe4b62f702d@oss.qualcomm.com>
Date: Tue, 25 Nov 2025 17:24:41 +0530
From: Krishna Kurapati PSSNV <krishna.kurapati@....qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] arm64: dts: qcom: lemans-evk: Add OTG support for
 primary USB controller



On 11/25/2025 5:09 PM, Konrad Dybcio wrote:
> On 11/25/25 12:04 PM, Krishna Kurapati wrote:
>> Enable OTG support for primary USB controller on EVK Platform. Add
>> HD3SS3220 Type-C port controller present between Type-C port and SoC
>> that provides role switch notifications to controller.
>>
>> Signed-off-by: Krishna Kurapati <krishna.kurapati@....qualcomm.com>
>> ---
> 
> [...]
> 
>> --- a/arch/arm64/boot/dts/qcom/lemans.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/lemans.dtsi
>> @@ -4026,7 +4026,27 @@ usb_0: usb@...0000 {
>>   			snps,dis-u1-entry-quirk;
>>   			snps,dis-u2-entry-quirk;
>>   
>> +			usb-role-switch;
>>   			status = "disabled";
>> +
>> +			ports {
>> +				#address-cells = <1>;
>> +				#size-cells = <0>;
>> +
>> +				port@0 {
>> +					reg = <0>;
>> +
>> +					usb3_0_hs_ep: endpoint {
> 
> The patch looks good, but I'm a little puzzled why the endpoints of 'usb_0' are
> named 'usb3_0'.. This will make the DTs look like:
> 
> &usb_0 {
> 	// foo
> };
> 
> &usb_1 {
> 	// foo
> };
> 
> // usb_0 children
> &usb3_0_hs_ep {
> 	// foo
> };
> 
> 
> &usb3_0_ss_ep {
> 	// foo
> };
> 
> // usb_1 children
> &usb3_1_hs_ep {
> 	// foo
> };
> 
> &usb3_1_ss_ep {
> 	// foo
> };
> 

Shall I rename them to "usb_0_dwc3_hs" and "usb_0_dwc3_ss" ?

Regards,
Krishna,