linux-kernel - Re: [PATCH v2 0/5] staging: rtl8723bs: FIELD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSWcq26kQ4s7NeRT@stanley.mountain>
Date: Tue, 25 Nov 2025 15:10:19 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Navaneeth K <knavaneeth786@...il.com>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org, david.laight@...box.com
Subject: Re: [PATCH v2 0/5] staging: rtl8723bs: FIELD_OFFSET macro cleanup

On Tue, Nov 25, 2025 at 11:20:54AM +0000, Navaneeth K wrote:
> This series cleans up the rtl8723bs driver by removing the custom
> FIELD_OFFSET macro and replacing its usages with the standard offsetof()
> from <linux/stddef.h>.
> 
> Changes in v2:
>   - Split the series for proper bisectability: the FIELD_OFFSET macro
>     definition is now removed in Patch 5 (after all usages are converted),
>     rather than in Patch 1.
>   - Patch 1: Now only removes unused RGTRY_OFT, RGTRY_SZ, BSSID_OFT, and
>     BSSID_SZ macros (dead code not used anywhere in the driver).
>   - Patch 2: Split long line to fit within 100 columns. Also added
>     <linux/stddef.h> include to basic_types.h to support offsetof usage.
>   - Patch 3: Fixed brace formatting issue caused by removing commented
>     code. Removed unnecessary outer parentheses, moved the inline
>     comment to its own line, and added braces to the else branch for
>     consistent style.
>   - Patch 5 (NEW): Remove FIELD_OFFSET definition now that it's unused.
> 

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>

regards,
dan carpenter