linux-kernel - Re: [PATCH] EDAC/amd64: Add support for family 19h, models 40h-4fh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251125121802.GEaSWeeg36pHTqMAlR@fat_crate.local>
Date: Tue, 25 Nov 2025 13:18:02 +0100
From: Borislav Petkov <bp@...en8.de>
To: Devang Vyas <devangnayanbhai.vyas@....com>
Cc: yazen.ghannam@....com, tony.luck@...el.com, linux-edac@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Ramesh Garidapuri <ramesh.garidapuri@....com>
Subject: Re: [PATCH] EDAC/amd64: Add support for family 19h, models 40h-4fh

On Mon, Nov 24, 2025 at 11:43:35PM +0530, Devang Vyas wrote:
> This patch updates the EDAC driver to include support

Avoid having "This patch" or "This commit" in the commit message. It is
tautologically useless.

Also, do

$ git grep 'This patch' Documentation/process

for more details.

> for AMD SoC family 19h models 40h-4fh to support
> Ryzen 6000 CPUs/APUs ("Rembrandt").
> 
> The added changes enhance the ability to detect and
> report memory errors on systems that utilize AMD SoCs
> from the specified family.

Lemme repeat my comment from last time:

"Use the commit message to explain why those need to load the EDAC driver at
all."

Your text still doesn't explain why amd64_edac should load on a client CPU:

https://en.wikipedia.org/wiki/Zen_3#Rembrandt

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette