linux-kernel - Re: [PATCH 6.12 000/565] 6.12.58-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSWleVyr9fUiu8Gu@duo.ucw.cz>
Date: Tue, 25 Nov 2025 13:47:53 +0100
From: Pavel Machek <pavel@...x.de>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	wozizhi@...weicloud.com
Cc: stable@...r.kernel.org, patches@...ts.linux.dev,
	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, linux@...ck-us.net, shuah@...nel.org,
	patches@...nelci.org, lkft-triage@...ts.linaro.org,
	jonathanh@...dia.com, f.fainelli@...il.com,
	sudipm.mukherjee@...il.com, rwarsow@....de, conor@...nel.org,
	hargar@...rosoft.com, broonie@...nel.org, achill@...ill.org,
	sr@...dewatkins.com
Subject: Re: [PATCH 6.12 000/565] 6.12.58-rc1 review

Hi!

> Zizhi Wo <wozizhi@...weicloud.com>
>     tty/vt: Add missing return value for VT_RESIZE in vt_ioctl()

This one was backported wrongly to 6.12:

+++ b/drivers/tty/vt/vt_ioctl.c
@@ -923,7 +923,9 @@ int vt_ioctl(struct tty_struct *tty,
 
                        if (vc) {
                                /* FIXME: review v tty lock */
-                               __vc_resize(vc_cons[i].d, cc, ll, true);
+                               ret = __vc_resize(vc_cons[i].d, cc, ll, true);
+                               if (ret)
+                                       return ret;
                        }
                }
                console_unlock();

It needs to do console_unlock() before returning.

Best regards,
								Pavel
-- 
In cooperation with DENX Software Engineering GmbH, HRB 165235 Munich,
Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)