linux-kernel - Re: [PATCH][next] nfp: tls: Avoid -Wflex-array-member-not-at-end warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251124183949.62d61b24@kernel.org>
Date: Mon, 24 Nov 2025 18:39:49 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc: Simon Horman <horms@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 oss-drivers@...igine.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH][next] nfp: tls: Avoid -Wflex-array-member-not-at-end
 warnings

On Thu, 20 Nov 2025 11:39:39 +0900 Gustavo A. R. Silva wrote:
>  struct nfp_crypto_req_add_front {
> -	struct nfp_ccm_hdr hdr;
> -	__be32 ep_id;
> -	u8 resv[3];
> -	u8 opcode;
> -	u8 key_len;
> -	__be16 ipver_vlan __packed;
> -	u8 l4_proto;
> +	/* New members MUST be added within the struct_group() macro below. */
> +	struct_group_tagged(nfp_crypto_req_add_front_hdr, __hdr,
> +		struct nfp_ccm_hdr hdr;
> +		__be32 ep_id;
> +		u8 resv[3];
> +		u8 opcode;
> +		u8 key_len;
> +		__be16 ipver_vlan __packed;
> +		u8 l4_proto;
> +	);
>  #define NFP_NET_TLS_NON_ADDR_KEY_LEN	8
>  	u8 l3_addrs[];
>  };
> +static_assert(offsetof(struct nfp_crypto_req_add_front, l3_addrs) ==
> +	      sizeof(struct nfp_crypto_req_add_front_hdr),
> +	      "struct member likely outside of struct_group_tagged()");
>  
>  struct nfp_crypto_req_add_back {
>  	__be16 src_port;
> @@ -55,14 +61,14 @@ struct nfp_crypto_req_add_back {
>  };
>  
>  struct nfp_crypto_req_add_v4 {
> -	struct nfp_crypto_req_add_front front;
> +	struct nfp_crypto_req_add_front_hdr front;
>  	__be32 src_ip;
>  	__be32 dst_ip;
>  	struct nfp_crypto_req_add_back back;
>  };
>  
>  struct nfp_crypto_req_add_v6 {
> -	struct nfp_crypto_req_add_front front;
> +	struct nfp_crypto_req_add_front_hdr front;
>  	__be32 src_ip[4];
>  	__be32 dst_ip[4];
>  	struct nfp_crypto_req_add_back back;
> diff --git a/drivers/net/ethernet/netronome/nfp/crypto/tls.c b/drivers/net/ethernet/netronome/nfp/crypto/tls.c
> index f252ecdcd2cd..a6d6a334c84b 100644
> --- a/drivers/net/ethernet/netronome/nfp/crypto/tls.c
> +++ b/drivers/net/ethernet/netronome/nfp/crypto/tls.c
> @@ -180,7 +180,8 @@ nfp_net_tls_set_ipv4(struct nfp_net *nn, struct nfp_crypto_req_add_v4 *req,
>  	req->front.key_len += sizeof(__be32) * 2;
>  
>  	if (direction == TLS_OFFLOAD_CTX_DIR_TX) {
> -		nfp_net_tls_assign_conn_id(nn, &req->front);
> +		nfp_net_tls_assign_conn_id(nn,
> +			container_of(&req->front, struct nfp_crypto_req_add_front, __hdr));

Once again you're making the code unacceptably ugly.
-- 
pw-bot: cr