linux-kernel - Re: [PATCH 4/4] ASoC: stm32: sai: clean up probe error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e0ef715-f34e-40b3-b1d8-21160c87fba4@foss.st.com>
Date: Tue, 25 Nov 2025 14:37:43 +0100
From: Olivier MOYSAN <olivier.moysan@...s.st.com>
To: Johan Hovold <johan@...nel.org>,
        Arnaud Pouliquen
	<arnaud.pouliquen@...s.st.com>,
        Mark Brown <broonie@...nel.org>
CC: Liam Girdwood <lgirdwood@...il.com>, Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        <linux-sound@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/4] ASoC: stm32: sai: clean up probe error path



On 11/24/25 11:49, Johan Hovold wrote:
> Use an error label for deregistering also the PCM DMA for consistency.
> 
> Signed-off-by: Johan Hovold <johan@...nel.org>

Reviewed-by: olivier moysan <olivier.moysan@...s.st.com>

Olivier

> ---
>   sound/soc/stm/stm32_sai_sub.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c
> index 5ae4d2577f28..450e1585edee 100644
> --- a/sound/soc/stm/stm32_sai_sub.c
> +++ b/sound/soc/stm/stm32_sai_sub.c
> @@ -1716,15 +1716,15 @@ static int stm32_sai_sub_probe(struct platform_device *pdev)
>   
>   	ret = snd_soc_register_component(&pdev->dev, &stm32_component,
>   					 &sai->cpu_dai_drv, 1);
> -	if (ret) {
> -		snd_dmaengine_pcm_unregister(&pdev->dev);
> -		goto err_unprepare_pclk;
> -	}
> +	if (ret)
> +		goto err_deregister_pcm_dma;
>   
>   	pm_runtime_enable(&pdev->dev);
>   
>   	return 0;
>   
> +err_deregister_pcm_dma:
> +	snd_dmaengine_pcm_unregister(&pdev->dev);
>   err_unprepare_pclk:
>   	clk_unprepare(sai->pdata->pclk);
>   	of_node_put(sai->np_sync_provider);