linux-kernel - Re: [PATCH] usb: gadget: renesas_usbf: Handle devm_pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSb2x6Qiru4KLOcy@black.igk.intel.com>
Date: Wed, 26 Nov 2025 13:47:03 +0100
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Haotian Zhang <vulab@...as.ac.cn>, herve.codina@...tlin.com,
	gregkh@...uxfoundation.org, linux-renesas-soc@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: renesas_usbf: Handle
 devm_pm_runtime_enable() errors

On Mon, Nov 24, 2025 at 02:15:14PM +0100, Geert Uytterhoeven wrote:
> On Mon, 24 Nov 2025 at 03:24, Haotian Zhang <vulab@...as.ac.cn> wrote:

> Thanks for your patch!

...

> > -       devm_pm_runtime_enable(&pdev->dev);
> > +       ret = devm_pm_runtime_enable(&pdev->dev);
> > +       if (ret)
> > +               return ret;
> 
> Perhaps insert a blank line here?
> 
> >         ret = pm_runtime_resume_and_get(&pdev->dev);
> >         if (ret < 0)
> >                 return ret;

FWIW, if not fixed yet, this driver from this line towards the end of
the function leaks the PM runtime reference count.

> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

-- 
With Best Regards,
Andy Shevchenko