linux-kernel - Re: [PATCH] serial: 8250-of: Fix style issues in 8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSb4Tr4iKaR_pqnA@black.igk.intel.com>
Date: Wed, 26 Nov 2025 13:53:34 +0100
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: "jempty.liang" <imntjempty@....com>
Cc: gregkh@...uxfoundation.org, jirislaby@...nel.org,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH] serial: 8250-of: Fix style issues in 8250_of.c

On Mon, Nov 17, 2025 at 03:41:17AM +0000, jempty.liang wrote:
> This patch resolves the warning "sizeof *port should be sizeof(*port)"
> detected by checkpatch.pl.

If you are going to submit more patches like this or related to sizeof, it
would be worth to mention that while sizeof is an operator, the coding style
recommends to use parentheses (but I haven't double checked this, feel free
to find it in the Coding Style documentation).

> -	memset(port, 0, sizeof *port);
> +	memset(port, 0, sizeof(*port));

>From C perspective the original one is okay.

-- 
With Best Regards,
Andy Shevchenko