linux-kernel - Re: [PATCH] regulator: core: Protect regulator_supply_alias_list with regulator_list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe36de30-9449-4d03-bb19-122604105bb5@sirena.org.uk>
Date: Wed, 26 Nov 2025 12:58:19 +0000
From: Mark Brown <broonie@...nel.org>
To: sparkhuang <huangshaobo3@...omi.com>
Cc: Liam Girdwood <lgirdwood@...il.com>,
	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>,
	linux-kernel@...r.kernel.org, weipengliang@...omi.com,
	wengjinfei@...omi.com, caodan1@...omi.com
Subject: Re: [PATCH] regulator: core: Protect regulator_supply_alias_list
 with regulator_list_mutex

On Wed, Nov 26, 2025 at 02:15:42PM +0800, sparkhuang wrote:

> -	map->alias_supply = alias_id;
> +	mutex_lock(&regulator_list_mutex);
> +	map = regulator_find_supply_alias(dev, id);
> +	if (map) {
> +		mutex_unlock(&regulator_list_mutex);
> +		kfree(new_map);
> +		return -EEXIST;
> +	}
>  
> +	new_map->src_dev = dev;
> +	new_map->src_supply = id;
> +	new_map->alias_dev = alias_dev;
> +	new_map->alias_supply = alias_id;
>  	list_add(&map->list, &regulator_supply_alias_list);
> -
> +	mutex_lock(&regulator_list_mutex);

This is locking regulator_list_mutex which is already locked, I think
you meant mutex_unlock().

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)