linux-kernel - Re: [PATCH 2/4] ACPI: button: Cancel hibernation if button is pressed during hibernation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <40627ddc-720b-42c5-948b-8d832d16e2ce@collabora.com>
Date: Wed, 26 Nov 2025 18:41:09 +0500
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: usama.anjum@...labora.com, "Rafael J. Wysocki" <rafael@...nel.org>,
 Len Brown <lenb@...nel.org>, Pavel Machek <pavel@...nel.org>,
 Danilo Krummrich <dakr@...nel.org>,
 Dmitry Torokhov <dmitry.torokhov@...il.com>,
 Thomas Gleixner <tglx@...utronix.de>, Peter Zijlstra <peterz@...radead.org>,
 linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pm@...r.kernel.org, linux-input@...r.kernel.org, kernel@...labora.com,
 superm1@...nel.org
Subject: Re: [PATCH 2/4] ACPI: button: Cancel hibernation if button is pressed
 during hibernation

On 11/26/25 12:38 PM, Greg Kroah-Hartman wrote:
> On Tue, Nov 25, 2025 at 09:41:22PM +0500, Muhammad Usama Anjum wrote:
>>>> While I've thought about increasing the speed, I've no concrete ideas yet.
>>>> The main problem is that its sequential in nature.
>>>
>>> Then fix that?
>> That's in the plan. But who knows when we get time to attempt that. 
> 
> Take the time to fix this properly first, don't paper over the issue by
> changing user/system interactions that will not be needed in the future
> when the real problem is resolved.
You're absolutely right, and I share the same philosophy.

However, I think the hibernation cancellation feature has standalone value
regardless of how much we optimize hibernation time. Even if we achieve
significant improvements (5-30% or more), there will still be scenarios where
users want to abort an in-progress hibernation.

I'm focusing on making this series more concise for next revision.

> 
>> First I need a board/machine with serial console access to view all logs in real
>> time. :)
> 
> usb debug cables might be your solution.
> 
> good luck!
> 
> greg k-h

-- 
---
Thanks,
Usama