linux-kernel - Re: [PATCH] x86/cpu/amd: Correct the microcode table for Zenbleed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251126144258.6dd61af7@pumpkin>
Date: Wed, 26 Nov 2025 14:42:58 +0000
From: david laight <david.laight@...box.com>
To: Borislav Petkov <bp@...en8.de>
Cc: Andrew Cooper <andrew.cooper3@...rix.com>, LKML
 <linux-kernel@...r.kernel.org>, Mario Limonciello
 <mario.limonciello@....com>, x86@...nel.org
Subject: Re: [PATCH] x86/cpu/amd: Correct the microcode table for Zenbleed

On Wed, 26 Nov 2025 13:44:53 +0100
Borislav Petkov <bp@...en8.de> wrote:

> On Wed, Nov 26, 2025 at 11:33:43AM +0000, Andrew Cooper wrote:
> > Sorry, this needs a {} terminator to be correct.  I'll send out a v2 in
> > a bit, assuming there are no other comments.  
> 
> I'm just glad that I'm not the only one to fall for this no-terminator shit.

Could you add an #define wrapper, eg

#define x86_match_min_microcode_rev(table) \
	x86_match_min_microcode_rev(table, ARRAY_COUNT(table))

to pass the count into the function?
Then the terminator can be made optional.

The data will be smaller, the code slightly larger.
So a net size gain since the performance can't be critical.

	David