linux-kernel - Re: [PATCH RESEND v6] checkpatch: add uninitialized pointer with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ed88d805835d38635899d591148d5daf88f77d7c.camel@gmail.com>
Date: Wed, 26 Nov 2025 20:14:34 +0530
From: ally heev <allyheev@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Dwaipayan Ray	
 <dwaipayanray1@...il.com>, Lukas Bulwahn <lukas.bulwahn@...il.com>, Joe
 Perches	 <joe@...ches.com>, Jonathan Corbet <corbet@....net>, Andy
 Whitcroft	 <apw@...onical.com>
Cc: workflows@...r.kernel.org, linux-doc@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Dan Carpenter <dan.carpenter@...aro.org>,
 David Hunter <david.hunter.linux@...il.com>, Shuah Khan
 <skhan@...uxfoundation.org>, Viresh Kumar	 <vireshk@...nel.org>, Nishanth
 Menon <nm@...com>, Stephen Boyd <sboyd@...nel.org>,  linux-pm
 <linux-pm@...r.kernel.org>, dan.j.williams@...el.com, Geert Uytterhoeven	
 <geert@...ux-m68k.org>, James Bottomley
 <James.Bottomley@...senpartnership.com>
Subject: Re: [PATCH RESEND v6] checkpatch: add uninitialized pointer with
 __free attribute check

On Wed, 2025-11-26 at 09:10 +0100, Krzysztof Kozlowski wrote:
> On 25/11/2025 17:11, ally heev wrote:
> > On Tue, 2025-11-25 at 16:09 +0100, Krzysztof Kozlowski wrote:
> > > On 25/11/2025 14:32, Ally Heev wrote:
> > > > uninitialized pointers with __free attribute can cause undefined
> > > > behavior as the memory randomly assigned to the pointer is freed
> > > > automatically when the pointer goes out of scope.
> > > > add check in checkpatch to detect such issues.
> > > > 
> > > > Suggested-by: Dan Carpenter <dan.carpenter@...aro.org>
> > > > Link: https://lore.kernel.org/all/8a4c0b43-cf63-400d-b33d-d9c447b7e0b9@suswa.mountain/
> > > > Link: https://lore.kernel.org/all/58fd478f408a34b578ee8d949c5c4b4da4d4f41d.camel@HansenPartnership.com/
> > > > Acked-by: Dan Williams <dan.j.williams@...el.com>
> > > > Signed-off-by: Ally Heev <allyheev@...il.com>
> > > 
> > > 
> > > <form letter>
> > > This is a friendly reminder during the review process.
> > > 
> > > It looks like you received a tag and forgot to add it.
> > > 
> > > If you do not know the process, here is a short explanation:
> > > Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
> > > of patchset, under or above your Signed-off-by tag, unless patch changed
> > > significantly (e.g. new properties added to the DT bindings). Tag is
> > > "received", when provided in a message replied to you on the mailing
> > > list. Tools like b4 can help here. However, there's no need to repost
> > > patches *only* to add the tags. The upstream maintainer will do that for
> > > tags received on the version they apply.
> > > 
> > > Please read:
> > > https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
> > > 
> > > If a tag was not added on purpose, please state why and what changed.
> > > </form letter>
> > > 
> > > 
> > > Best regards,
> > > Krzysztof
> > 
> > Oopsie. I should have sent a new version instead of resending a failed
> > one. I have updated the `UNINITIALIZED_PTR_WITH_FREE` error description
> > in the checkpatch doc as outlined in v6 changelog, so, didn't add a
> > Reviewed-by tag
> 
> 
> Again, your changelog should explain the reason. Second, you implemented
> reviewer suggestion, received the tag so why do you think that Rb tag
> does not apply?
> 
> Best regards,
> Krzysztof

Sorry again :(. I thought the new changes, although minor, would entail
new comments. I have experienced this in my old patches

Regards,
Ally