linux-kernel - Re: [PATCH -next] memcg: Remove inc/dec_lruvec_kmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <e8d2c5b3-eee2-46fd-9d67-422428bd8bf5@bytedance.com>
Date: Wed, 26 Nov 2025 10:49:14 +0800
From: "Qi Zheng" <zhengqi.arch@...edance.com>
To: "Chen Ridong" <chenridong@...weicloud.com>, <hannes@...xchg.org>, 
	<mhocko@...nel.org>, <roman.gushchin@...ux.dev>, 
	<shakeel.butt@...ux.dev>, <muchun.song@...ux.dev>, 
	<akpm@...ux-foundation.org>, <david@...nel.org>, 
	<lorenzo.stoakes@...cle.com>, <axelrasmussen@...gle.com>, 
	<yuanchu@...gle.com>, <weixugc@...gle.com>
Cc: <cgroups@...r.kernel.org>, <linux-mm@...ck.org>, 
	<linux-kernel@...r.kernel.org>, <lujialin4@...wei.com>, 
	<chenridong@...wei.com>
Subject: Re: [PATCH -next] memcg: Remove inc/dec_lruvec_kmem_state helpers

On 11/26/25 10:04 AM, Chen Ridong wrote:
> From: Chen Ridong <chenridong@...wei.com>
> 
> The dec_lruvec_kmem_state helper is unused by any caller and can be safely
> removed. Meanwhile, the inc_lruvec_kmem_state helper is only referenced by
> shadow_lru_isolate, retaining these two helpers is unnecessary. This patch
> removes both helper functions to eliminate redundant code.

Make sense.

Acked-by: Qi Zheng <zhengqi.arch@...edance.com>

> 
> Signed-off-by: Chen Ridong <chenridong@...wei.com>
> ---
>   include/linux/memcontrol.h | 10 ----------
>   mm/workingset.c            |  2 +-
>   2 files changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index d35390f9892a..0651865a4564 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -1452,16 +1452,6 @@ struct slabobj_ext {
>   #endif
>   } __aligned(8);
>   
> -static inline void inc_lruvec_kmem_state(void *p, enum node_stat_item idx)
> -{
> -	mod_lruvec_kmem_state(p, idx, 1);
> -}
> -
> -static inline void dec_lruvec_kmem_state(void *p, enum node_stat_item idx)
> -{
> -	mod_lruvec_kmem_state(p, idx, -1);
> -}
> -
>   static inline struct lruvec *parent_lruvec(struct lruvec *lruvec)
>   {
>   	struct mem_cgroup *memcg;
> diff --git a/mm/workingset.c b/mm/workingset.c
> index 892f6fe94ea9..e9f05634747a 100644
> --- a/mm/workingset.c
> +++ b/mm/workingset.c
> @@ -749,7 +749,7 @@ static enum lru_status shadow_lru_isolate(struct list_head *item,
>   	if (WARN_ON_ONCE(node->count != node->nr_values))
>   		goto out_invalid;
>   	xa_delete_node(node, workingset_update_node);
> -	inc_lruvec_kmem_state(node, WORKINGSET_NODERECLAIM);
> +	mod_lruvec_kmem_state(node, WORKINGSET_NODERECLAIM, 1);
>   
>   out_invalid:
>   	xa_unlock_irq(&mapping->i_pages);