linux-kernel - Re: [PATCH] staging: fluke_gpib: use kzalloc instead of kmalloc + memset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aScwSm0RoNVRj68q@stanley.mountain>
Date: Wed, 26 Nov 2025 19:52:26 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Tomasz Sadowski <tsdwski@...il.com>
Cc: Dave Penkler <dpenkler@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: fluke_gpib: use kzalloc instead of kmalloc +
 memset

On Wed, Nov 26, 2025 at 04:48:52PM +0100, Tomasz Sadowski wrote:
> > You did not specify a description of why the patch is needed, or
> > possibly, any description at all, in the email body. [...]
> 
> Thanks, the commit message now includes a proper description.
> The patch itself has not changed.
> 
> I also realized that the previous subject line might have been incorrect.
> The correct subject should be:
> 
>     staging: gpib: eastwood: use kzalloc instead of kmalloc + memset
> 

All this is weird commentary to put into a patch...


> Use kzalloc() instead of kmalloc() + memset() to simplify memory allocation.
> 
> Also use sizeof(*board->private_data) instead of repeating the struct name.
> This avoids duplication and keeps the code correct if the struct name
> changes in the future.
> 
> Signed-off-by: Tomasz Sadowski <tsdwski@...il.com>
> ---

This isn't how to send a v2 patch.

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

regards,
dan carpenter