linux-kernel - Re: [PATCH v2] hwmon: sy7636a: Fix regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bcc61b94-29aa-47b6-b399-dd5e70db9418@roeck-us.net>
Date: Wed, 26 Nov 2025 09:03:37 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Haotian Zhang <vulab@...as.ac.cn>
Cc: Alistair Francis <alistair@...stair23.me>, linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] hwmon: sy7636a: Fix regulator_enable resource leak on
 error path

On Thu, Nov 27, 2025 at 12:26:02AM +0800, Haotian Zhang wrote:
> In sy7636a_sensor_probe(), regulator_enable() is called but if
> devm_hwmon_device_register_with_info() fails, the function returns
> without calling regulator_disable(), leaving the regulator enabled
> and leaking the reference count.
> 
> Switch to devm_regulator_get_enable() to automatically
> manage the regulator resource.
> 
> Fixes: de34a4053250 ("hwmon: sy7636a: Add temperature driver for sy7636a")
> Suggested-by: Guenter Roeck <linux@...ck-us.net>
> Signed-off-by: Haotian Zhang <vulab@...as.ac.cn>

Applied.

Thanks,
Guenter