[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20251126-feature_tilcdc-v1-6-49b9ef2e3aa0@bootlin.com>
Date: Wed, 26 Nov 2025 18:35:48 +0100
From: "Kory Maincent (TI.com)" <kory.maincent@...tlin.com>
To: Jyri Sarha <jyri.sarha@....fi>,
Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Russell King <linux@...linux.org.uk>,
Bartosz Golaszewski <brgl@...ev.pl>, Tony Lindgren <tony@...mide.com>,
Andrzej Hajda <andrzej.hajda@...el.com>,
Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>,
Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>
Cc: Markus Schneider-Pargmann <msp@...libre.com>,
Luca Ceresoli <luca.ceresoli@...tlin.com>,
Louis Chauvet <louis.chauvet@...tlin.com>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
Miguel Gazquez <miguel.gazquez@...tlin.com>,
dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-omap@...r.kernel.org,
"Kory Maincent (TI.com)" <kory.maincent@...tlin.com>
Subject: [PATCH 06/21] dt-bindings: display: tilcdc: Remove panel binding
Remove the deprecated ti,tilcdc,panel binding which violates devicetree
design principles by placing display controller configuration
(DMA burst size, FIFO thresholds, AC bias, etc.) inside the panel node
instead of the controller node where it belongs.
This non-standard binding has several critical issues:
- Mixes controller-specific hardware parameters with panel properties
- Lacks the standard port/endpoint graph for panel connections
- Cannot work with the standard DRM panel infrastructure
- Forces vendor-specific binding instead of reusable panel-dpi binding
The tilcdc driver has been updated to work with standard DRM panels and
bridges, and all in-tree users have been migrated to use the generic
panel-dpi binding with proper port/endpoint connections. Controller
parameters like fifo-threshold are now correctly specified in the
tilcdc node itself.
While removing bindings is exceptional, keeping this binding would:
- Perpetuate incorrect devicetree design patterns
- Require maintaining a non-standard panel driver solely for tilcdc
- Block proper integration with the DRM panel subsystem
- Prevent devicetree reusability across different display controllers
This removal completes the migration to standard DRM panel bindings.
Signed-off-by: Kory Maincent (TI.com) <kory.maincent@...tlin.com>
---
.../devicetree/bindings/display/tilcdc/panel.txt | 66 ----------------------
1 file changed, 66 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/tilcdc/panel.txt b/Documentation/devicetree/bindings/display/tilcdc/panel.txt
deleted file mode 100644
index 808216310ea27..0000000000000
--- a/Documentation/devicetree/bindings/display/tilcdc/panel.txt
+++ /dev/null
@@ -1,66 +0,0 @@
-Device-Tree bindings for tilcdc DRM generic panel output driver
-
-Required properties:
- - compatible: value should be "ti,tilcdc,panel".
- - panel-info: configuration info to configure LCDC correctly for the panel
- - ac-bias: AC Bias Pin Frequency
- - ac-bias-intrpt: AC Bias Pin Transitions per Interrupt
- - dma-burst-sz: DMA burst size
- - bpp: Bits per pixel
- - fdd: FIFO DMA Request Delay
- - sync-edge: Horizontal and Vertical Sync Edge: 0=rising 1=falling
- - sync-ctrl: Horizontal and Vertical Sync: Control: 0=ignore
- - raster-order: Raster Data Order Select: 1=Most-to-least 0=Least-to-most
- - fifo-th: DMA FIFO threshold
- - display-timings: typical videomode of lcd panel. Multiple video modes
- can be listed if the panel supports multiple timings, but the 'native-mode'
- should be the preferred/default resolution. Refer to
- Documentation/devicetree/bindings/display/panel/display-timing.txt for display
- timing binding details.
-
-Optional properties:
-- backlight: phandle of the backlight device attached to the panel
-- enable-gpios: GPIO pin to enable or disable the panel
-
-Recommended properties:
- - pinctrl-names, pinctrl-0: the pincontrol settings to configure
- muxing properly for pins that connect to TFP410 device
-
-Example:
-
- /* Settings for CDTech_S035Q01 / LCD3 cape: */
- lcd3 {
- compatible = "ti,tilcdc,panel";
- pinctrl-names = "default";
- pinctrl-0 = <&bone_lcd3_cape_lcd_pins>;
- backlight = <&backlight>;
- enable-gpios = <&gpio3 19 0>;
-
- panel-info {
- ac-bias = <255>;
- ac-bias-intrpt = <0>;
- dma-burst-sz = <16>;
- bpp = <16>;
- fdd = <0x80>;
- sync-edge = <0>;
- sync-ctrl = <1>;
- raster-order = <0>;
- fifo-th = <0>;
- };
- display-timings {
- native-mode = <&timing0>;
- timing0: 320x240 {
- hactive = <320>;
- vactive = <240>;
- hback-porch = <21>;
- hfront-porch = <58>;
- hsync-len = <47>;
- vback-porch = <11>;
- vfront-porch = <23>;
- vsync-len = <2>;
- clock-frequency = <8000000>;
- hsync-active = <0>;
- vsync-active = <0>;
- };
- };
- };
--
2.43.0
Powered by blists - more mailing lists