linux-kernel - Re: [PATCH] iio: accel: adxl380: fix check for unavailable "INT1" interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSdDT4upO9shVq0S@smile.fi.intel.com>
Date: Wed, 26 Nov 2025 20:13:35 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Francesco Lavra <flavra@...libre.com>
Cc: Ramona Gradinariu <ramona.gradinariu@...log.com>,
	Antoniu Miclaus <antoniu.miclaus@...log.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: accel: adxl380: fix check for unavailable "INT1"
 interrupt

On Wed, Nov 26, 2025 at 03:46:24PM +0100, Francesco Lavra wrote:
> fwnode_irq_get_byname() returns a negative value on failure.

...

>  		st->irq = fwnode_irq_get_byname(dev_fwnode(st->dev), "INT1");
> -		if (st->irq > 0)
> +		if (st->irq < 0)
>  			return dev_err_probe(st->dev, -ENODEV,

Please, also fix this.

>  					     "no interrupt name specified");

Otherwise a good catch!

-- 
With Best Regards,
Andy Shevchenko