linux-kernel - Re: [PATCH] mfd: mc13xxx-core: Fix memory leak in mc13xxx_add_subdevice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202511270127.8j2J6hwF-lkp@intel.com>
Date: Thu, 27 Nov 2025 02:17:32 +0800
From: kernel test robot <lkp@...el.com>
To: Abdun Nihaal <nihaal@....iitm.ac.in>, lee@...nel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Abdun Nihaal <nihaal@....iitm.ac.in>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: mc13xxx-core: Fix memory leak in
 mc13xxx_add_subdevice_pdata()

Hi Abdun,

kernel test robot noticed the following build errors:

[auto build test ERROR on lee-mfd/for-mfd-next]
[also build test ERROR on lee-mfd/for-mfd-fixes lee-leds/for-leds-next linus/master v6.18-rc7 next-20251126]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Abdun-Nihaal/mfd-mc13xxx-core-Fix-memory-leak-in-mc13xxx_add_subdevice_pdata/20251126-012428
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
patch link:    https://lore.kernel.org/r/20251125171936.98101-1-nihaal%40cse.iitm.ac.in
patch subject: [PATCH] mfd: mc13xxx-core: Fix memory leak in mc13xxx_add_subdevice_pdata()
config: x86_64-buildonly-randconfig-003-20251126 (https://download.01.org/0day-ci/archive/20251127/202511270127.8j2J6hwF-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251127/202511270127.8j2J6hwF-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511270127.8j2J6hwF-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/mfd/mc13xxx-core.c:388:3: error: call to undeclared function 'kfree'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     388 |                 kfree(cell.name);
         |                 ^
   1 error generated.


vim +/kfree +388 drivers/mfd/mc13xxx-core.c

   364	
   365	static int mc13xxx_add_subdevice_pdata(struct mc13xxx *mc13xxx,
   366			const char *format, void *pdata, size_t pdata_size)
   367	{
   368		int ret;
   369		char buf[30];
   370		const char *name = mc13xxx_get_chipname(mc13xxx);
   371	
   372		struct mfd_cell cell = {
   373			.platform_data = pdata,
   374			.pdata_size = pdata_size,
   375		};
   376	
   377		/* there is no asnprintf in the kernel :-( */
   378		if (snprintf(buf, sizeof(buf), format, name) > sizeof(buf))
   379			return -E2BIG;
   380	
   381		cell.name = kmemdup(buf, strlen(buf) + 1, GFP_KERNEL);
   382		if (!cell.name)
   383			return -ENOMEM;
   384	
   385		ret = mfd_add_devices(mc13xxx->dev, -1, &cell, 1, NULL, 0,
   386				       regmap_irq_get_domain(mc13xxx->irq_data));
   387		if (ret)
 > 388			kfree(cell.name);
   389		return ret;
   390	}
   391	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki