linux-kernel - Re: [PATCH net-next v6 5/5] selftests: netconsole: validate target resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <hjty4katdz2lmkbjqt4tourk6nf5eq3x2nh6if4ay5xdslpr6n@3htraj5r67py>
Date: Wed, 26 Nov 2025 20:01:11 +0000
From: Andre Carvalho <asantostc@...il.com>
To: Breno Leitao <leitao@...ian.org>, Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Shuah Khan <shuah@...nel.org>, 
	Simon Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next v6 5/5] selftests: netconsole: validate target
 resume

On Fri, Nov 21, 2025 at 12:49:04PM +0000, Andre Carvalho wrote:
> +	echo "${BINDMODE} : Test passed" >&2
> +done
> +
> +trap - EXIT
> +exit "${ksft_pass}"

Shellcheck complains about this line given that it expects that exported
variables from other files are always uppercase. I'm going to submit a new
version of this test using ${EXIT_STATUS} instead, which is the same approach
taken by a netcons_torture.sh which was recently added.

We may want to refactor these tests to make use of other selftest's functions
that actually mutate EXIT_STATUS based on the intermediary results of the tests
(by using log_test and other functions from lib.sh) which I think may also
help with making result logging a bit more in line with other tests. I'd like to
do this in a separate series and migrate all tests, if we agree on this direction.

> 
> -- 
> 2.52.0
> 

-- 
Andre Carvalho