linux-kernel - Re: [PATCH] fs/nls: Fix inconsistency between utf8_to_utf32() and utf32_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aSdtxhgmFsjqERvl@smile.fi.intel.com>
Date: Wed, 26 Nov 2025 23:14:46 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Armin Wolf <W_Armin@....de>
Cc: hansg@...nel.org, ilpo.jarvinen@...ux.intel.com,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/nls: Fix inconsistency between utf8_to_utf32() and
 utf32_to_utf8()

On Wed, Nov 26, 2025 at 11:13:50PM +0200, Andy Shevchenko wrote:
> On Wed, Nov 26, 2025 at 09:43:55PM +0100, Armin Wolf wrote:
> > After commit 25524b619029 ("fs/nls: Fix utf16 to utf8 conversion"),
> > the return values of utf8_to_utf32() and utf32_to_utf8() are
> > inconsistent when encountering an error: utf8_to_utf32() returns -1,
> > while utf32_to_utf8() returns errno codes. Fix this inconsistency
> > by modifying utf8_to_utf32() to return errno codes as well.
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>
> 
> Thanks!

Note, you might need a Fixes tag as the original one was marked as Fixes.

-- 
With Best Regards,
Andy Shevchenko