linux-kernel - Re: [PATCH] kbuild: Ensure .dtbo targets are applied to a base .dtb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqKJEZodVSo-6bZBcUTc0TfNCs6bEGfvy9ZdZbmSbu=cSA@mail.gmail.com>
Date: Wed, 26 Nov 2025 16:25:24 -0600
From: Rob Herring <robh@...nel.org>
To: Nicolas Schier <nsc@...nel.org>
Cc: Nathan Chancellor <nathan@...nel.org>, devicetree@...r.kernel.org, 
	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kbuild: Ensure .dtbo targets are applied to a base .dtb

On Wed, Nov 26, 2025 at 2:49 PM Nicolas Schier <nsc@...nel.org> wrote:
>
> On Fri, Nov 14, 2025 at 04:27:58PM -0600, Rob Herring (Arm) wrote:
> > It is a requirement that DT overlays in the kernel are applied at build
> > time to a base DTB in order to validate they can be applied and to
> > validate them against the DT schemas. DT overlays on their own may be
> > incomplete and can't be validated.
> >
> > Add a kbuild check so this doesn't have to be checked and fixed
> > periodically.
> >
> > Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> > ---
> >  scripts/Makefile.dtbs | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/scripts/Makefile.dtbs b/scripts/Makefile.dtbs
> > index 2d321b813600..15473edc2589 100644
> > --- a/scripts/Makefile.dtbs
> > +++ b/scripts/Makefile.dtbs
> > @@ -10,6 +10,13 @@ real-dtb-y := $(call real-search, $(dtb-y), .dtb, -dtbs)
> >  # Base DTB that overlay is applied onto
> >  base-dtb-y := $(filter %.dtb, $(call real-search, $(multi-dtb-y), .dtb, -dtbs))
> >
> > +# Ensure that any .dtbo is applied to at least one base .dtb. Otherwise, it
> > +# does not get validated.
> > +applied-dtbo := $(filter %.dtbo, \
> > +     $(call real-search, $(call multi-search, $(dtb-y) $(dtb-), .dtb, -dtbs), .dtb, -dtbs))
> > +unapplied-dtbo := $(filter-out $(applied-dtbo),$(filter %.dtbo, $(dtb-y)))
> > +$(if $(unapplied-dtbo), $(warning .dtbo is not applied to any base: $(unapplied-dtbo)))
> > +
> >  dtb-y           := $(addprefix $(obj)/, $(dtb-y))
> >  multi-dtb-y     := $(addprefix $(obj)/, $(multi-dtb-y))
> >  real-dtb-y      := $(addprefix $(obj)/, $(real-dtb-y))
> > --
> > 2.51.0
> >
>
> Acked-by: Nicolas Schier <nsc@...nel.org>

Thanks!

> Do you take this via DT tree?

Yes, I'll take it.

Rob