| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <044cf7ef-8361-4426-8aca-c2bac63c6ab7@amd.com>
Date: Wed, 26 Nov 2025 12:02:01 +0530
From: Sandipan Das <sandipan.das@....com>
To: Ian Rogers <irogers@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Benjamin Gray <bgray@...ux.ibm.com>, Caleb Biggers
<caleb.biggers@...el.com>, Edward Baker <edward.baker@...el.com>,
Ingo Molnar <mingo@...hat.com>, James Clark <james.clark@...aro.org>,
Jing Zhang <renyu.zj@...ux.alibaba.com>, Jiri Olsa <jolsa@...nel.org>,
John Garry <john.g.garry@...cle.com>, Leo Yan <leo.yan@....com>,
Namhyung Kim <namhyung@...nel.org>, Perry Taylor <perry.taylor@...el.com>,
Peter Zijlstra <peterz@...radead.org>, Samantha Alt
<samantha.alt@...el.com>, Thomas Falcon <thomas.falcon@...el.com>,
Weilin Wang <weilin.wang@...el.com>, Xu Yang <xu.yang_2@....com>,
linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH v8 51/52] perf jevents: Add cycles breakdown metric for
arm64/AMD/Intel
On 11/13/2025 8:50 AM, Ian Rogers wrote:
> Breakdown cycles to user, kernel and guest. Add a common_metrics.py
> file for such metrics.
>
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
> tools/perf/pmu-events/Build | 2 +-
> tools/perf/pmu-events/amd_metrics.py | 2 ++
> tools/perf/pmu-events/arm64_metrics.py | 2 ++
> tools/perf/pmu-events/common_metrics.py | 19 +++++++++++++++++++
> tools/perf/pmu-events/intel_metrics.py | 2 ++
> 5 files changed, 26 insertions(+), 1 deletion(-)
> create mode 100644 tools/perf/pmu-events/common_metrics.py
>
> diff --git a/tools/perf/pmu-events/Build b/tools/perf/pmu-events/Build
> index f7d67d03d055..a3d7a04f0abf 100644
> --- a/tools/perf/pmu-events/Build
> +++ b/tools/perf/pmu-events/Build
> @@ -44,7 +44,7 @@ $(LEGACY_CACHE_JSON): $(LEGACY_CACHE_PY)
> $(call rule_mkdir)
> $(Q)$(call echo-cmd,gen)$(PYTHON) $(LEGACY_CACHE_PY) > $@
>
> -GEN_METRIC_DEPS := pmu-events/metric.py
> +GEN_METRIC_DEPS := pmu-events/metric.py pmu-events/common_metrics.py
>
> # Generate AMD Json
> ZENS = $(shell ls -d pmu-events/arch/x86/amdzen*)
> diff --git a/tools/perf/pmu-events/amd_metrics.py b/tools/perf/pmu-events/amd_metrics.py
> index b2e3e2883022..5bc53fcf6448 100755
> --- a/tools/perf/pmu-events/amd_metrics.py
> +++ b/tools/perf/pmu-events/amd_metrics.py
> @@ -4,6 +4,7 @@ import argparse
> import math
> import os
> from typing import Optional
> +from common_metrics import Cycles
> from metric import (d_ratio, has_event, max, Event, JsonEncodeMetric,
> JsonEncodeMetricGroupDescriptions, Literal, LoadEvents,
> Metric, MetricGroup, Select)
> @@ -694,6 +695,7 @@ def main() -> None:
> AmdSwpf(),
> AmdUopCache(),
> AmdUpc(),
> + Cycles(),
> Idle(),
> Rapl(),
> UncoreL3(),
> diff --git a/tools/perf/pmu-events/arm64_metrics.py b/tools/perf/pmu-events/arm64_metrics.py
> index 9678253e2e0e..ac518e7f1120 100755
> --- a/tools/perf/pmu-events/arm64_metrics.py
> +++ b/tools/perf/pmu-events/arm64_metrics.py
> @@ -3,6 +3,7 @@
> import argparse
> import os
> from typing import Optional
> +from common_metrics import Cycles
> from metric import (d_ratio, Event, JsonEncodeMetric, JsonEncodeMetricGroupDescriptions,
> LoadEvents, Metric, MetricGroup)
>
> @@ -173,6 +174,7 @@ def main() -> None:
>
> all_metrics = MetricGroup("", [
> Arm64Topdown(),
> + Cycles(),
> ])
>
> if _args.metricgroups:
> diff --git a/tools/perf/pmu-events/common_metrics.py b/tools/perf/pmu-events/common_metrics.py
> new file mode 100644
> index 000000000000..fcdfb9d3e648
> --- /dev/null
> +++ b/tools/perf/pmu-events/common_metrics.py
> @@ -0,0 +1,19 @@
> +# SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause)
> +from metric import (d_ratio, Event, Metric, MetricGroup)
> +
> +
> +def Cycles() -> MetricGroup:
> + cyc_k = Event("cpu\\-cycles:kHh") # exclude user and guest
> + cyc_g = Event("cpu\\-cycles:G") # exclude host
> + cyc_u = Event("cpu\\-cycles:uH") # exclude kernel, hypervisor and guest
> + cyc = cyc_k + cyc_g + cyc_u
> +
> + return MetricGroup("lpm_cycles", [
> + Metric("lpm_cycles_total", "Total number of cycles", cyc, "cycles"),
> + Metric("lpm_cycles_user", "User cycles as a percentage of all cycles",
> + d_ratio(cyc_u, cyc), "100%"),
> + Metric("lpm_cycles_kernel", "Kernel cycles as a percentage of all cycles",
> + d_ratio(cyc_k, cyc), "100%"),
> + Metric("lpm_cycles_guest", "Hypervisor guest cycles as a percentage of all cycles",
> + d_ratio(cyc_g, cyc), "100%"),
> + ], description="cycles breakdown per privilege level (users, kernel, guest)")
> diff --git a/tools/perf/pmu-events/intel_metrics.py b/tools/perf/pmu-events/intel_metrics.py
> index d56bab7337df..52035433b505 100755
> --- a/tools/perf/pmu-events/intel_metrics.py
> +++ b/tools/perf/pmu-events/intel_metrics.py
> @@ -6,6 +6,7 @@ import math
> import os
> import re
> from typing import Optional
> +from common_metrics import Cycles
> from metric import (d_ratio, has_event, max, source_count, CheckPmu, Event,
> JsonEncodeMetric, JsonEncodeMetricGroupDescriptions,
> Literal, LoadEvents, Metric, MetricConstraint, MetricGroup,
> @@ -1095,6 +1096,7 @@ def main() -> None:
> LoadEvents(directory)
>
> all_metrics = MetricGroup("", [
> + Cycles(),
> Idle(),
> Rapl(),
> Smi(),
Reviewed-by: Sandipan Das <sandipan.das@....com>
Powered by blists - more mailing lists