linux-kernel - Re: [PATCH] efi/riscv: Remove the useless failure return message print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXE0ic5Jx3J75qocFgvUPMqQF4Xsqf4CCnaYggWJ35bUiQ@mail.gmail.com>
Date: Wed, 26 Nov 2025 07:38:06 +0100
From: Ard Biesheuvel <ardb@...nel.org>
To: Qiang Ma <maqianga@...ontech.com>
Cc: Paul Walmsley <pjw@...nel.org>, palmer@...belt.com, aou@...s.berkeley.edu, 
	alex@...ti.fr, linux-efi@...r.kernel.org, linux-riscv@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] efi/riscv: Remove the useless failure return message print

On Wed, 26 Nov 2025 at 03:53, Qiang Ma <maqianga@...ontech.com> wrote:
>
>
> 在 2025/11/26 08:27, Paul Walmsley 写道:
> > On Fri, 31 Oct 2025, Qiang Ma wrote:
> >
> >> In the efi_create_mapping() in arch/riscv/kernel/efi.c,
> >> the return value is always 0, and this debug message
> >> is unnecessary. So, remove it.
> >>
> >> Signed-off-by: Qiang Ma <maqianga@...ontech.com>
> > Considering that Ard doesn't think efi_create_mapping() should be changed
> > to remove the return value, and that the ARM version of this code retains
> > the debug message, we should probably keep things the way they are.  But
> > if you can get a Reviewed-by: or an Acked-by: from Ard, I'd take it.
> Hi, Ard, what are your suggestions for this patch?
>
> Could you add a Reviewed-by: or an Acked-by: to this patch?

I already queued this up in efi/next