linux-kernel - Re: [PATCH 4/6] mfd: max77759: modify irq configs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1fafb9117a9faa32222a55efc77794156635d105.camel@linaro.org>
Date: Wed, 26 Nov 2025 07:36:35 +0000
From: André Draszik <andre.draszik@...aro.org>
To: Amit Sunil Dhamne <amitsd@...gle.com>, Sebastian Reichel
 <sre@...nel.org>,  Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,  Lee Jones
 <lee@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Badhri
 Jagan Sridharan	 <badhri@...gle.com>, Heikki Krogerus
 <heikki.krogerus@...ux.intel.com>,  Peter Griffin
 <peter.griffin@...aro.org>, Tudor Ambarus <tudor.ambarus@...aro.org>, Alim
 Akhtar	 <alim.akhtar@...sung.com>
Cc: linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-usb@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, RD
 Babiera <rdbabiera@...gle.com>, Kyle Tso <kyletso@...gle.com>
Subject: Re: [PATCH 4/6] mfd: max77759: modify irq configs

On Wed, 2025-11-26 at 06:44 +0000, André Draszik wrote:
> Hi Amit,
> 
> On Tue, 2025-11-25 at 17:10 -0800, Amit Sunil Dhamne wrote:
> > Hi André,
> > 
> > On 11/23/25 10:21 PM, André Draszik wrote:
> > > Hi Amit,
> > > 
> > > Thanks for your patches to enable the charger!
> > 
> > Ack!
> > 
> > 
> > > > From: Amit Sunil Dhamne <amitsd@...gle.com>
> > > > 
> > > > Define specific bit-level masks for charger's registers and modify the
> > > > irq mask for charger irq_chip. Also, configure the max77759 interrupt
> > > > lines as active low to all interrupt registrations to ensure the
> > > > interrupt controllers are configured with the correct trigger type.
> > > > 
> > > > Signed-off-by: Amit Sunil Dhamne <amitsd@...gle.com>
> > > > ---
> > > >   drivers/mfd/max77759.c       | 24 +++++++++++++++++-------
> > > >   include/linux/mfd/max77759.h |  9 +++++++++
> > > >   2 files changed, 26 insertions(+), 7 deletions(-)
> > > > 
> > > > diff --git a/drivers/mfd/max77759.c b/drivers/mfd/max77759.c
> > > > index 6cf6306c4a3b..5fe22884f362 100644
> > > > --- a/drivers/mfd/max77759.c
> > > > +++ b/drivers/mfd/max77759.c
> > > > @@ -256,8 +256,17 @@ static const struct regmap_irq max77759_topsys_irqs[] = {
> > > >   };
> > > >   
> > > >   static const struct regmap_irq max77759_chgr_irqs[] = {
> > > > -	REGMAP_IRQ_REG(MAX77759_CHARGER_INT_1, 0, GENMASK(7, 0)),
> > > > -	REGMAP_IRQ_REG(MAX77759_CHARGER_INT_2, 1, GENMASK(7, 0)),
> > > > +	REGMAP_IRQ_REG(MAX77759_CHARGER_INT_1, 0,
> > > > +		       MAX77759_CHGR_REG_CHG_INT_AICL |
> > > > +		       MAX77759_CHGR_REG_CHG_INT_CHGIN |
> > > > +		       MAX77759_CHGR_REG_CHG_INT_CHG |
> > > > +		       MAX77759_CHGR_REG_CHG_INT_INLIM),
> > > > +	REGMAP_IRQ_REG(MAX77759_CHARGER_INT_2, 1,
> > > > +		       MAX77759_CHGR_REG_CHG_INT2_BAT_OILO |
> > > > +		       MAX77759_CHGR_REG_CHG_INT2_CHG_STA_CC |
> > > > +		       MAX77759_CHGR_REG_CHG_INT2_CHG_STA_CV |
> > > > +		       MAX77759_CHGR_REG_CHG_INT2_CHG_STA_TO |
> > > > +		       MAX77759_CHGR_REG_CHG_INT2_CHG_STA_DONE),
> > > >   };
> 
> You should also add the remaining bits in each register here, so that the
> regulator-irq can mask them when no user exists. It will only touch the
  ^^^^^^^^^^^^^
  regmap-irq

A.