linux-kernel - Re: [PATCH] tools: bpf: remove runqslower tool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <67d85605b603942683e285ed0f88d463fd85bfe0972b92e787c15891c0b1e32c@mail.kernel.org>
Date: Wed, 26 Nov 2025 07:58:03 +0000 (UTC)
From: bot+bpf-ci@...nel.org
To: hoyeon.lee@...e.com,bpf@...r.kernel.org
Cc: hoyeon.lee@...e.com,ast@...nel.org,daniel@...earbox.net,andrii@...nel.org,martin.lau@...ux.dev,eddyz87@...il.com,song@...nel.org,yonghong.song@...ux.dev,john.fastabend@...il.com,kpsingh@...nel.org,sdf@...ichev.me,haoluo@...gle.com,jolsa@...nel.org,shuah@...nel.org,nathan@...nel.org,nick.desaulniers+lkml@...il.com,morbo@...gle.com,justinstitt@...gle.com,tony.ambardar@...il.com,charlie@...osinc.com,linux-kernel@...r.kernel.org,linux-kselftest@...r.kernel.org,llvm@...ts.linux.dev,ast@...nel.org,andrii@...nel.org,daniel@...earbox.net,martin.lau@...nel.org,eddyz87@...il.com,yonghong.song@...ux.dev,clm@...a.com,ihor.solodrai@...ux.dev
Subject: Re: [PATCH] tools: bpf: remove runqslower tool

> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> index bac22265e..4e8d32318 100644
> --- a/tools/testing/selftests/bpf/Makefile
> +++ b/tools/testing/selftests/bpf/Makefile

[ ... ]

> @@ -209,8 +208,6 @@ HOST_INCLUDE_DIR	:= $(INCLUDE_DIR)
>  endif
>  HOST_BPFOBJ := $(HOST_BUILD_DIR)/libbpf/libbpf.a
>  RESOLVE_BTFIDS := $(HOST_BUILD_DIR)/resolve_btfids/resolve_btfids
> -RUNQSLOWER_OUTPUT := $(BUILD_DIR)/runqslower/
> -

The commit removes the RUNQSLOWER_OUTPUT variable definition here, but
the variable is still referenced later in the file. Around line 232 in
the MAKE_DIRS assignment, the undefined variable RUNQSLOWER_OUTPUT
remains in the list:

MAKE_DIRS := $(sort $(BUILD_DIR)/libbpf $(HOST_BUILD_DIR)/libbpf \
               $(BUILD_DIR)/bpftool $(HOST_BUILD_DIR)/bpftool \
               $(HOST_BUILD_DIR)/resolve_btfids \
               $(RUNQSLOWER_OUTPUT) $(INCLUDE_DIR))

Should this reference be removed from MAKE_DIRS to complete the
cleanup?


---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/19696291804