linux-kernel - Re: [PATCH 1/1] nvme-fabrics: add ENOKEY to no retry criteria for authentication failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3ac161db-5be6-4edf-b392-6769dc507e60@flourine.local>
Date: Wed, 26 Nov 2025 09:12:31 +0100
From: Daniel Wagner <dwagner@...e.de>
To: Justin Tee <justintee8345@...il.com>
Cc: Hannes Reinecke <hare@...e.de>, linux-nvme@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, jsmart2021@...il.com, justin.tee@...adcom.com, 
	Daniel Wagner <wagi@...nel.org>
Subject: Re: [PATCH 1/1] nvme-fabrics: add ENOKEY to no retry criteria for
 authentication failures

On Tue, Nov 25, 2025 at 11:34:40AM +0100, Daniel Wagner wrote:
> As I said your fix is good and addresses the reconnect with an invalid
> key problem. Though it doesn't address the issue that 'nvme connect'
> will still return success.

To my surprise this is not happening. nvme/041 is behaving for all
transport the same. I've extended blktests to check the return code for
'nvme connect'

  https://github.com/linux-blktests/blktests/pull/216

So your patch fixes this problem completely. Nice!

Thanks,
Daniel