linux-kernel - Re: RE: [EXT] Re: [PATCH 5/6] spi: imx: support dynamic burst length for ECSPI DMA mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251126-aloof-stalwart-worm-343112-mkl@pengutronix.de>
Date: Wed, 26 Nov 2025 09:44:53 +0100
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Carlos Song <carlos.song@....com>
Cc: "broonie@...nel.org" <broonie@...nel.org>, Frank Li <frank.li@....com>, 
	"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>, "kernel@...gutronix.de" <kernel@...gutronix.de>, 
	"festevam@...il.com" <festevam@...il.com>, "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>, 
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>, 
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: RE: [EXT] Re: [PATCH 5/6] spi: imx: support dynamic burst length
 for ECSPI DMA mode

On 26.11.2025 08:34:18, Carlos Song wrote:
> > On 25.11.2025 18:06:17, Carlos Song wrote:
> > > +static int spi_imx_dma_transfer(struct spi_imx_data *spi_imx,
> > > +				struct spi_transfer *transfer)
> > > +{
> > > +	bool word_delay = transfer->word_delay.value != 0;
> > > +	int ret;
> > > +	int i;
> > > +
> > > +	ret = spi_imx_dma_data_prepare(spi_imx, transfer, word_delay);
> > > +	if (ret < 0) {
> > > +		transfer->error |= SPI_TRANS_FAIL_NO_START;
> > > +		dev_err(spi_imx->dev, "DMA data prepare fail\n");
> > > +		goto fallback_pio;
> > > +	}
> > > +
> > > +	spi_imx->rx_offset = 0;
> > > +
> > > +	/* Each dma_package performs a separate DMA transfer once */
> > > +	for (i = 0; i < spi_imx->dma_package_num; i++) {
> > > +		ret = spi_imx_dma_map(spi_imx, &spi_imx->dma_data[i]);
> > > +		if (ret < 0) {
> > > +			transfer->error |= SPI_TRANS_FAIL_NO_START;
> >
> > What about:
> >
> > if (i == 0)
> >         transfer->error |= SPI_TRANS_FAIL_NO_START;
> >
> > instead of removing the later?
>
> 	for (i = 0; i < spi_imx->dma_package_num; i++) {
> 		ret = spi_imx_dma_map(spi_imx, &spi_imx->dma_data[i]);
> 		if (ret < 0) {
> 			if (I == 0)
                            ^ i
> 				transfer->error |= SPI_TRANS_FAIL_NO_START;
> 			dev_err(spi_imx->dev, "DMA map fail\n");
> 			break;
> 		}
> ...
> -	/* If no any dma package data is transferred, fallback to PIO mode transfer */
> -	if ((transfer->error & SPI_TRANS_FAIL_NO_START) && i != 0)
> -		transfer->error &= !SPI_TRANS_FAIL_NO_START;
>
> 	return ret;
>
> Just like this? I accept this. I can fix this in V2

Yes, with the fixed typo.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)