linux-kernel - Re: [PATCH v3 0/1] platform/x86: serial-multi-instantiate: ACPI example code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8af3d19b-a204-4120-bb08-3de21e6a60cb@kernel.org>
Date: Wed, 26 Nov 2025 10:05:30 +0100
From: Hans de Goede <hansg@...nel.org>
To: Baojun Xu <baojun.xu@...com>, tiwai@...e.de
Cc: ilpo.jarvinen@...ux.intel.com, broonie@...nel.org,
 andriy.shevchenko@...ux.intel.com, alsa-devel@...a-project.org,
 shenghao-ding@...com, 13916275206@....com,
 platform-driver-x86@...r.kernel.org, linux-sound@...r.kernel.org,
 linux-kernel@...r.kernel.org, letitia.tsai@...com
Subject: Re: [PATCH v3 0/1] platform/x86: serial-multi-instantiate: ACPI
 example code

Hi Baojun Xu,

On 26-Nov-25 9:17 AM, Baojun Xu wrote:
> The tas2781-hda supports multi-projects, In some projects,
> GpioInt was dropped due to no IRQ connection.
> See the example code below:
> 
> But in smi_i2c_probe(), smi_spi_probe() (serial-multi-instantiate.c),
> if looking for IRQ by smi_get_irq() fails, it will return an error,
> will not add new device, and cause smi_probe to fail.
> So need to add an exception case for these situations.
> BTW, this patch will take effect on both I2C and SPI devices.
> 
> Device (SPKR)
> {
>     Name (_ADR, One)
>     Name (_HID, "TXNW2781")
>     Method (_CRS, 0, NotSerialized)
>     {
>         Name (RBUF, ResourceTemplate ()
>         {
>             I2cSerialBusV2 (0x0038, ...)
>             I2cSerialBusV2 (0x0039, ...)
>             // GpioInt (Edge, ...) { 0x0000 }
>             //"GpioInt (...) {}" was commented out due to no IRQ connection.
>         })
>         Return (RBUF)
>     }
> }
> 
> Signed-off-by: Baojun Xu <baojun.xu@...com>

Thank you, the patch itself looks good, but the above information
from the cover-letter really should be in the commit message of
the patch itself.

Can you please send a v4 with this info added to the commit
message ?

Regards,

Hans




> 
> Baojun Xu (1):
>   platform/x86: serial-multi-instantiate: Add IRQ_RESOURCE_OPT for IRQ
>     missing projects
> 
>  drivers/platform/x86/serial-multi-instantiate.c | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
>