linux-kernel - Re: [PATCH 2/3] pinctrl: mediatek: Add acpi support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD++jL=h4ZEgrjgGOfgFyAXBM7EL91ZD-La82UQ7GPOXv8h9WQ@mail.gmail.com>
Date: Wed, 26 Nov 2025 10:10:15 +0100
From: Linus Walleij <linusw@...nel.org>
To: Lei Xue <lei.xue@...iatek.com>, 
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, 
	Lorenzo Pieralisi <lpieralisi@...nel.org>, Hanjun Guo <guohanjun@...wei.com>, 
	Sudeep Holla <sudeep.holla@....com>
Cc: Sean Wang <sean.wang@...nel.org>, Linus Walleij <linus.walleij@...aro.org>, 
	Matthias Brugger <matthias.bgg@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, linux-kernel@...r.kernel.org, 
	linux-mediatek@...ts.infradead.org, linux-gpio@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, yong.mao@...iatek.com, 
	qingliang.li@...iatek.com, Fred-WY.Chen@...iatek.com, 
	ot_cathy.xu@...iatek.com, ot_shunxi.zhang@...iatek.com, 
	ot_yaoy.wang@...iatek.com, ot_ye.wang@...iatek.com, 
	linux-acpi@...r.kernel.org
Subject: Re: [PATCH 2/3] pinctrl: mediatek: Add acpi support

On Tue, Nov 25, 2025 at 3:36 AM Lei Xue <lei.xue@...iatek.com> wrote:

> Add acpi support in the common part of pinctrl driver. Parsing
> hardware base addresses and irq number to initialize eint
> accroding to the acpi table data.
>
> Signed-off-by: Lei Xue <lei.xue@...iatek.com>

I'd ideally like Andy and the ARM64 ACPI maintainers look on
this. (Added to To:) and CC linux-acpi@...r.kernel.org.

I'm not aware of the best way to deal with ACPI in combined drivers
but things like this:

> -               hw->base[i] = devm_platform_ioremap_resource_byname(pdev,
> -                                       hw->soc->base_names[i]);
> +               hw->base[i] = is_of_node(fwnode)
> +                       ? devm_platform_ioremap_resource_byname(pdev, hw->soc->base_names[i])
> +                       : devm_platform_get_and_ioremap_resource(pdev, i, NULL);

Just look really quirky, I think there are better ways to go about
this and sometimes the ACPI maintainers give some good
pushback about the firmware as well.

Yours,
Linus Walleij