linux-kernel - Re: [PATCH v5 0/4] USB Type-C alternate mode priorities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSbHHXIFYAqLzxzY@kuha>
Date: Wed, 26 Nov 2025 11:23:41 +0200
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Andrei Kuchynski <akuchynski@...omium.org>
Cc: Abhishek Pandit-Subedi <abhishekpandit@...omium.org>,
	Benson Leung <bleung@...omium.org>,
	Jameson Thies <jthies@...gle.com>,
	Tzung-Bi Shih <tzungbi@...nel.org>, linux-usb@...r.kernel.org,
	chrome-platform@...ts.linux.dev,
	Guenter Roeck <groeck@...omium.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
	"Christian A. Ehrhardt" <lk@...e.de>,
	Abel Vesa <abel.vesa@...aro.org>,
	Pooja Katiyar <pooja.katiyar@...el.com>,
	Venkat Jayaraman <venkat.jayaraman@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 0/4] USB Type-C alternate mode priorities

Hi Andrei, guys,

Mon, Nov 24, 2025 at 12:46:35PM +0000, Andrei Kuchynski kirjoitti:
> This patch series introduces a mechanism for setting USB Type-C alternate
> mode priorities. It allows the user to specify their preferred order for
> mode selection, such as USB4, Thunderbolt, or DisplayPort.
> 
> A new sysfs attribute named 'priority' is exposed to provide user-space
> control over the mode selection process.
> 
> This series was tested on a Android OS device running kernel 6.18.0-rc6.
> 
> Changes in v5:
> - Patches 3 and 4 (v4) have been consolidated into a singular patch,
> keeping the mode priority implementation within drivers/usb/typec/class.c.
> 
> Andrei Kuchynski (4):
>   usb: typec: Add mode_control field to port property
>   platform/chrome: cros_ec_typec: Set no_mode_control flag
>   usb: typec: ucsi: Set no_mode_control flag
>   usb: typec: Expose alternate mode priority via sysfs
> 
>  Documentation/ABI/testing/sysfs-class-typec | 11 +++
>  drivers/platform/chrome/cros_ec_typec.c     |  1 +
>  drivers/usb/typec/class.c                   | 99 ++++++++++++++++++++-
>  drivers/usb/typec/class.h                   |  1 +
>  drivers/usb/typec/ucsi/ucsi.c               |  1 +
>  include/linux/usb/typec.h                   |  2 +
>  include/linux/usb/typec_altmode.h           |  1 +
>  7 files changed, 112 insertions(+), 4 deletions(-)

These are okay by me. I think we can move to the next step. But I'm
not sure we apply these before that, because the file has no effect
at the moment.

Br,

-- 
heikki