linux-kernel - Re: [PATCH V2 2/5] dm: ignore discard return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7cec7231-33f7-44ec-b82e-f12fba15392f@kernel.org>
Date: Wed, 26 Nov 2025 18:26:39 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Wilfred Mallawa <wilfred.opensource@...il.com>,
 Chaitanya Kulkarni <ckulkarnilinux@...il.com>, axboe@...nel.dk,
 agk@...hat.com, snitzer@...nel.org, mpatocka@...hat.com, song@...nel.org,
 yukuai@...as.com, hch@....de, sagi@...mberg.me, kch@...dia.com,
 jaegeuk@...nel.org, chao@...nel.org, cem@...nel.org
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
 dm-devel@...ts.linux.dev, linux-raid@...r.kernel.org,
 linux-nvme@...ts.infradead.org, linux-f2fs-devel@...ts.sourceforge.net,
 linux-xfs@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH V2 2/5] dm: ignore discard return value

On 11/26/25 8:41 AM, Wilfred Mallawa wrote:
> On Sun, 2025-11-23 at 18:57 -0800, Chaitanya Kulkarni wrote:
>> __blkdev_issue_discard() always returns 0, making all error checking
>> at call sites dead code.
>>
>> For dm-thin change issue_discard() return type to void, in
>> passdown_double_checking_shared_status() remove the r assignment from
>> return value of the issue_discard(), for end_discard() hardcod value
> 
> Hey Chaitanya,
> 
> Typo here s/hardcod/hardcode. Otherwise, with the split as other have
> suggested:

s/hardcod/hardcoded

> 
> 
> Reviewed-by: Wilfred Mallawa <wilfred.mallawa@....com>
> 
> Regards,
> Wilfred
> 


-- 
Damien Le Moal
Western Digital Research