linux-kernel - Re: [PATCH v7 6/6] vfio/nvgrace-gpu: wait for the GPU mem to be ready

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SA1PR12MB7199DBC4470892FAFE797C1BB0DEA@SA1PR12MB7199.namprd12.prod.outlook.com>
Date: Wed, 26 Nov 2025 09:49:49 +0000
From: Ankit Agrawal <ankita@...dia.com>
To: Shameer Kolothum <skolothumtho@...dia.com>, "jgg@...pe.ca" <jgg@...pe.ca>,
	Yishai Hadas <yishaih@...dia.com>, "kevin.tian@...el.com"
	<kevin.tian@...el.com>, "alex@...zbot.org" <alex@...zbot.org>, Aniket Agashe
	<aniketa@...dia.com>, Vikram Sethi <vsethi@...dia.com>, Matt Ochs
	<mochs@...dia.com>
CC: "Yunxiang.Li@....com" <Yunxiang.Li@....com>, "yi.l.liu@...el.com"
	<yi.l.liu@...el.com>, "zhangdongdong@...incomputing.com"
	<zhangdongdong@...incomputing.com>, Avihai Horon <avihaih@...dia.com>,
	"bhelgaas@...gle.com" <bhelgaas@...gle.com>, "peterx@...hat.com"
	<peterx@...hat.com>, "pstanner@...hat.com" <pstanner@...hat.com>, Alistair
 Popple <apopple@...dia.com>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Neo Jia
	<cjia@...dia.com>, Kirti Wankhede <kwankhede@...dia.com>, "Tarun Gupta
 (SW-GPU)" <targupta@...dia.com>, Zhi Wang <zhiw@...dia.com>, Dan Williams
	<danw@...dia.com>, Dheeraj Nigam <dnigam@...dia.com>, Krishnakant Jaju
	<kjaju@...dia.com>
Subject: Re: [PATCH v7 6/6] vfio/nvgrace-gpu: wait for the GPU mem to be ready

>> +     ret = vfio_pci_core_setup_barmap(vdev, 0);
>> +     if (ret)
>> +             return ret;
>
> Should make sure vfio_pci_core_disable() is called on err path above.

Thanks Shameer for the review! Yeah, we should not have that if (ret)
check and let the flow fall to the vfio_pci_core_disable().

> With that,
> Reviewed-by: Shameer Kolothum <skolothumtho@...dia.com>