linux-kernel - Re: [PATCH v2] mailbox: omap-mailbox: Check for pending msgs only when mbox is exclusive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251126095116.GA6168@francesco-nb>
Date: Wed, 26 Nov 2025 10:51:16 +0100
From: Francesco Dolcini <francesco@...cini.it>
To: jassisinghbrar@...il.com, Beleswar Padhi <b-padhi@...com>
Cc: linux-kernel@...r.kernel.org, hiago.franco@...adex.com,
	francesco.dolcini@...adex.com, afd@...com, hnagalla@...com,
	u-kumar1@...com, nm@...com, vigneshr@...com
Subject: Re: [PATCH v2] mailbox: omap-mailbox: Check for pending msgs only
 when mbox is exclusive

Hello Jassi,

On Tue, Nov 04, 2025 at 01:41:11AM +0530, Beleswar Padhi wrote:
> On TI K3 devices, the mailbox resides in the Always-On power domain
> (LPSC_main_alwayson) and is shared among multiple processors. The
> mailbox is not solely exclusive to Linux.
> 
> Currently, the suspend path checks all FIFO queues for pending messages
> and blocks suspend if any are present. This behavior is unnecessary for
> K3 devices, since some of the FIFOs are used for RTOS<->RTOS
> communication and are independent of Linux.
> 
> For FIFOs used in Linux<->RTOS communication, any pending message would
> trigger an interrupt, which naturally prevents suspend from completing.
> Hence, there is no need for the mailbox driver to explicitly check for
> pending messages on K3 platforms.
> 
> Introduce a device match flag to indicate whether the mailbox instance
> is exclusive to Linux, and skip the pending message check for
> non-exclusive instances (such as in K3).
> 
> Fixes: a49f991e740f ("arm64: dts: ti: k3-am62-verdin: Add missing cfg for TI IPC Firmware")
> Closes: https://lore.kernel.org/all/sid7gtg5vay5qgicsl6smnzwg5mnneoa35cempt5ddwjvedaio@hzsgcx6oo74l/
> Signed-off-by: Beleswar Padhi <b-padhi@...com>

What's the status of this? It's fixing a real issue, and it has been
tested and reviewed. Any blocker to merge it?

Thanks
Francesco