linux-kernel - RE: [Intel-wired-lan] [PATCH net] iavf: Implement settime64 with -EOPNOTSUPP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DS4PPF7551E655202B3D3E09FA4E6B07C59E5DEA@DS4PPF7551E6552.namprd11.prod.outlook.com>
Date: Wed, 26 Nov 2025 10:03:36 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: "Schmidt, Michal" <mschmidt@...hat.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Richard Cochran
	<richardcochran@...il.com>, Mateusz Polchlopek
	<mateusz.polchlopek@...el.com>, Sai Krishna <saikrishnag@...vell.com>, "Simon
 Horman" <horms@...nel.org>, "Keller, Jacob E" <jacob.e.keller@...el.com>
CC: Tim Hostetler <thostet@...gle.com>, Ahmed Zaki <ahmed.zaki@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH net] iavf: Implement settime64 with
 -EOPNOTSUPP



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Michal Schmidt
> Sent: Wednesday, November 26, 2025 10:49 AM
> To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; Andrew Lunn <andrew+netdev@...n.ch>; David
> S. Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub
> Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Richard Cochran
> <richardcochran@...il.com>; Mateusz Polchlopek
> <mateusz.polchlopek@...el.com>; Sai Krishna <saikrishnag@...vell.com>; Simon
> Horman <horms@...nel.org>; Keller, Jacob E <jacob.e.keller@...el.com>
> Cc: Tim Hostetler <thostet@...gle.com>; Ahmed Zaki <ahmed.zaki@...el.com>;
> intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: [Intel-wired-lan] [PATCH net] iavf: Implement settime64 with -
> EOPNOTSUPP
> 
> ptp_clock_settime() assumes every ptp_clock has implemented settime64().
> Stub it with -EOPNOTSUPP to prevent a NULL dereference.
> 
> The fix is similar to commit 329d050bbe63 ("gve: Implement settime64 with -
> EOPNOTSUPP").
> 
> Fixes: d734223b2f0d ("iavf: add initial framework for registering PTP
> clock")
> Signed-off-by: Michal Schmidt <mschmidt@...hat.com>
> ---
>  drivers/net/ethernet/intel/iavf/iavf_ptp.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_ptp.c
> b/drivers/net/ethernet/intel/iavf/iavf_ptp.c
> index b4d5eda2e84f..9cbd8c154031 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_ptp.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_ptp.c
> @@ -252,6 +252,12 @@ static int iavf_ptp_gettimex64(struct ptp_clock_info
> *info,
>  	return iavf_read_phc_indirect(adapter, ts, sts);  }
> 
> +static int iavf_ptp_settime64(struct ptp_clock_info *info,
> +			      const struct timespec64 *ts)
> +{
> +	return -EOPNOTSUPP;
> +}
> +
>  /**
>   * iavf_ptp_cache_phc_time - Cache PHC time for performing timestamp
> extension
>   * @adapter: private adapter structure
> @@ -320,6 +326,7 @@ static int iavf_ptp_register_clock(struct iavf_adapter
> *adapter)
>  		 KBUILD_MODNAME, dev_name(dev));
>  	ptp_info->owner = THIS_MODULE;
>  	ptp_info->gettimex64 = iavf_ptp_gettimex64;
> +	ptp_info->settime64 = iavf_ptp_settime64;
>  	ptp_info->do_aux_work = iavf_ptp_do_aux_work;
> 
>  	clock = ptp_clock_register(ptp_info, dev);
> --
> 2.51.1

Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>