linux-kernel - Re: [net-next v2] dt-bindings: can: mpfs: document resets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251126-famous-hummingbird-of-fruition-13a9ac-mkl@pengutronix.de>
Date: Wed, 26 Nov 2025 11:24:42 +0100
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Conor Dooley <conor@...nel.org>
Cc: linux-kernel@...r.kernel.org, 
	Conor Dooley <conor.dooley@...rochip.com>, Daire McNamara <daire.mcnamara@...rochip.com>, 
	Vincent Mailhol <mailhol@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, linux-riscv@...ts.infradead.org, linux-can@...r.kernel.org, 
	devicetree@...r.kernel.org
Subject: Re: [net-next v2] dt-bindings: can: mpfs: document resets

Hello,

can I get a review from the DT people?

regards,
Marc

On 21.11.2025 13:42:30, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@...rochip.com>
>
> The CAN cores on Polarfire SoC both have a reset. The platform firmware
> brings both cores out of reset, but the linux driver must use them
> during normal operation. The resets should have been made required, but
> this is one of the things that can happen when the binding is written
> without driver support.
>
> Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller")
> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
> ---
> This is the second mistake in this binding, both spotted because of the
> driver being written (although this one sat downstream for a while for
> w/e reason). I wish I could say that I'd send the driver soon, but I am
> busy upstreaming things I wrote and therefore understand at the moment,
> so a driver that I'd have to go understand and review before sending is
> low priority, sorry!
>
> v2: update the example too...
>
> CC: Conor Dooley <conor.dooley@...rochip.com>
> CC: Daire McNamara <daire.mcnamara@...rochip.com>
> CC: Marc Kleine-Budde <mkl@...gutronix.de>
> CC: Vincent Mailhol <mailhol@...nel.org>
> CC: Rob Herring <robh@...nel.org>
> CC: Krzysztof Kozlowski <krzk+dt@...nel.org>
> CC: linux-riscv@...ts.infradead.org
> CC: linux-can@...r.kernel.org
> CC: devicetree@...r.kernel.org
> CC: linux-kernel@...r.kernel.org
> ---
>  .../devicetree/bindings/net/can/microchip,mpfs-can.yaml      | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml
> index 1219c5cb601f..519a11fbe972 100644
> --- a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml
> +++ b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml
> @@ -32,11 +32,15 @@ properties:
>        - description: AHB peripheral clock
>        - description: CAN bus clock
>
> +  resets:
> +    maxItems: 1
> +
>  required:
>    - compatible
>    - reg
>    - interrupts
>    - clocks
> +  - resets
>
>  additionalProperties: false
>
> @@ -46,6 +50,7 @@ examples:
>          compatible = "microchip,mpfs-can";
>          reg = <0x2010c000 0x1000>;
>          clocks = <&clkcfg 17>, <&clkcfg 37>;
> +        resets = <&clkcfg 17>;
>          interrupt-parent = <&plic>;
>          interrupts = <56>;
>      };
> --
> 2.51.0
>
>
>

--
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)