linux-kernel - Re: [f2fs-dev] [PATCH V3 6/6] xfs: ignore discard return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251126103323.GB26228@lst.de>
Date: Wed, 26 Nov 2025 11:33:23 +0100
From: Christoph Hellwig <hch@....de>
To: Yongpeng Yang <yangyongpeng.storage@...il.com>
Cc: Chaitanya Kulkarni <ckulkarnilinux@...il.com>, axboe@...nel.dk,
	agk@...hat.com, snitzer@...nel.org, mpatocka@...hat.com,
	song@...nel.org, yukuai@...as.com, hch@....de, sagi@...mberg.me,
	kch@...dia.com, jaegeuk@...nel.org, chao@...nel.org, cem@...nel.org,
	dm-devel@...ts.linux.dev, linux-raid@...r.kernel.org,
	Johannes Thumshirn <johannes.thumshirn@....com>,
	linux-kernel@...r.kernel.org, linux-nvme@...ts.infradead.org,
	linux-f2fs-devel@...ts.sourceforge.net, linux-block@...r.kernel.org,
	bpf@...r.kernel.org, linux-xfs@...r.kernel.org,
	Yongpeng Yang <yangyongpeng@...omi.com>
Subject: Re: [f2fs-dev] [PATCH V3 6/6] xfs: ignore discard return value

On Wed, Nov 26, 2025 at 10:37:10AM +0800, Yongpeng Yang wrote:
>>   				xfs_gbno_to_daddr(xg, busyp->bno),
>>   				XFS_FSB_TO_BB(mp, busyp->length),
>>   				GFP_KERNEL, &bio);
>
> If blk_alloc_discard_bio() fails to allocate a bio inside
> __blkdev_issue_discard(),

It won't, because mempool allocations will not fail if they can
sleep as they can here.