linux-kernel - Re: [PATCH] mm/memblock: only mark/clear KHO scratch memory when needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <md65ppfkqim2kepsx6igvezpcnr4hx3g2dxfdojsgx4rligwfg@u5dejfzmirfc>
Date: Wed, 26 Nov 2025 10:40:46 +0000
From: Kiryl Shutsemau <kirill@...temov.name>
To: Usama Arif <usamaarif642@...il.com>
Cc: rppt@...nel.org, Andrew Morton <akpm@...ux-foundation.org>, 
	changyuanl@...gle.com, graf@...zon.com, leitao@...ian.org, thevlad@...a.com, 
	pratyush@...nel.org, dave.hansen@...ux.intel.com, linux-mm@...ck.org, 
	linux-kernel@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH] mm/memblock: only mark/clear KHO scratch memory when
 needed

On Wed, Nov 26, 2025 at 07:20:51AM +0000, Usama Arif wrote:
> @@ -1126,8 +1126,11 @@ int __init_memblock memblock_reserved_mark_noinit(phys_addr_t base, phys_addr_t
>   */
>  __init int memblock_mark_kho_scratch(phys_addr_t base, phys_addr_t size)
>  {
> -	return memblock_setclr_flag(&memblock.memory, base, size, 1,
> -				    MEMBLOCK_KHO_SCRATCH);
> +	if (IS_ENABLED(CONFIG_MEMBLOCK_KHO_SCRATCH) && is_kho_boot())

It makes me wounder why CONFIG_MEMBLOCK_KHO_SCRATCH exists? It seems to
be a proxy for CONFIG_KEXEC_HANDOVER which is the only option that
selects it and does it always.

Can we make s/CONFIG_MEMBLOCK_KHO_SCRATCH/CONFIG_KEXEC_HANDOVER/ and
remove IS_ENABLED() from this check? Just is_kho_boot() is enough.


-- 
  Kiryl Shutsemau / Kirill A. Shutemov