linux-kernel - Re: [PATCH 6.12 000/565] 6.12.58-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <0J4wVn9EZlfvRPNqx8nSODm77O0ErR5JMPhZe35m07lKoJoh9BQHAyH167l2S-cYMQDDGLsRM9IKtY9YEwPvqfXduwmg12aaW591N2f9iT0=@protonmail.com>
Date: Wed, 26 Nov 2025 12:21:30 +0000
From: Jari Ruusu <jariruusu@...tonmail.com>
To: Pavel Machek <pavel@...x.de>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "wozizhi@...weicloud.com" <wozizhi@...weicloud.com>, "stable@...r.kernel.org" <stable@...r.kernel.org>, "patches@...ts.linux.dev" <patches@...ts.linux.dev>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>, "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>, "linux@...ck-us.net" <linux@...ck-us.net>, "shuah@...nel.org" <shuah@...nel.org>, "patches@...nelci.org" <patches@...nelci.org>, "lkft-triage@...ts.linaro.org" <lkft-triage@...ts.linaro.org>, "jonathanh@...dia.com" <jonathanh@...dia.com>, "f.fainelli@...il.com" <f.fainelli@...il.com>, "sudipm.mukherjee@...il.com" <sudipm.mukherjee@...il.com>, "rwarsow@....de" <rwarsow@....de>, "conor@...nel.org" <conor@...nel.org>, "hargar@...rosoft.com" <hargar@...rosoft.com>, "broonie@...nel.org" <broonie@...nel.org>, "achill@...ill.org" <achill@...ill.org>, "sr@...dewatkins.com" <sr@...dewatkins.com>
Subject: Re: [PATCH 6.12 000/565] 6.12.58-rc1 review

Pavel Machek <pavel@...x.de> wrote:
> > Zizhi Wo <wozizhi@...weicloud.com>
> >     tty/vt: Add missing return value for VT_RESIZE in vt_ioctl()
> 
> This one was backported wrongly to 6.12:
> 
> +++ b/drivers/tty/vt/vt_ioctl.c
> @@ -923,7 +923,9 @@ int vt_ioctl(struct tty_struct *tty,
>  
>                         if (vc) {
>                                 /* FIXME: review v tty lock */
> -                               __vc_resize(vc_cons[i].d, cc, ll, true);
> +                               ret = __vc_resize(vc_cons[i].d, cc, ll, true);
> +                               if (ret)
> +                                       return ret;
>                         }
>                 }
>                 console_unlock();
> 
> It needs to do console_unlock() before returning.

I have already sent 2 emails about this, but Greg's to-do
list seems to be very long, or something like that.

https://lore.kernel.org/lkml/zuLBWV-yhJXc0iM4l5T-O63M-kKmI2FlUSVgZl6B3WubvFEHRbBYQyhKsRcK4YyKk_iePF4STJihe7hx5H3KCU2KblG32oXwsxn9tzpTm5w=@protonmail.com/

https://lore.kernel.org/lkml/8mT8aJsAQPfUnmI5mmsgbUweQAptUFDu5XqhrxPPI1DgJr7GPpbwrpQQW22Nj7fsBc5M5YKG8g0EceNQ_b3d-RPhk6RSQgGCqvaVzzWSIQw=@protonmail.com/

That second email has a small test program to demo the
problem and a patch to fix it for 6.12.58+ and 6.17.8+

--
Jari Ruusu  4096R/8132F189 12D6 4C3A DCDA 0AA4 27BD  ACDF F073 3C80 8132 F189