linux-kernel - Re: [PATCH] Revert "arm64: dts: rockchip: fix audio-supply for Rock Pi 4"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ab1d240f-4130-4088-9ead-9fb562ee9ad2@kwiboo.se>
Date: Thu, 27 Nov 2025 16:10:38 +0100
From: Jonas Karlman <jonas@...boo.se>
To: Quentin Schulz <foss+kernel@...il.net>, FUKAUMI Naoki <naoki@...xa.com>,
 Heiko Stuebner <heiko@...ech.de>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Alex Bee <knaerzche@...il.com>,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
 Quentin Schulz <quentin.schulz@...rry.de>, stable@...r.kernel.org,
 Heinrich Schuchardt <xypron.glpk@....de>
Subject: Re: [PATCH] Revert "arm64: dts: rockchip: fix audio-supply for Rock
 Pi 4"

Hi Quentin,

On 11/27/2025 3:36 PM, Quentin Schulz wrote:
> From: Quentin Schulz <quentin.schulz@...rry.de>
> 
> This reverts commit 8240e87f16d17a9592c9d67857a3dcdbcb98f10d.
> 
> The original commit claimed that APIO5 IO domain (supplied with
> audio-supply) is supplied by RK808-D Buck 4 as stated in the schematics.
> 
> The linked PDF has two non-schematics pages where APIO5 indeed is said
> to be 1.8V. Reading the actual schematics[1][2][3][4][5][6][7][8], this
> is actually wrong as APIO5 is supplied VCC_3V0 which is LDO8 from
> RK808-D and is 3.0V instead of 1.8V from vcca1v8_codec.
> 
> This fixes the console disappearing in U-Boot, where the Device Tree is
> imported from the Linux kernel repo, when the IO domain driver is built,
> as reported by Heinrich[9]. As to why this breaks the console while the
> serial is not exposed on any of the pins on the bank in the APIO5
> domain, that is a well-kept secret by the SoC for now.
> 
> The issue "fixed" by the original commit will need to be fixed another
> way.
> 
> [1] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/4ap/radxa_rock_4ap_v1600_schematic.pdf
> [2] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/4ap/radxa_rock_4ap_v1730_schematic.pdf
> [3] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/4bp/radxa_rock_4bp_v1600_schematic.pdf
> [4] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/4bp/radxa_rock_4bp_v1730_schematic.pdf
> [5] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/ROCK-4-SE-V1.53-SCH.pdf
> [6] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/4b/ROCK_4B_v1.52_SCH.pdf
> [7] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/4a/ROCK_4A_V1.52_SCH.pdf
> [8] https://dl.radxa.com/rockpi4/docs/hw/rockpi4/rockpi4_v13_sch_20181112.pdf
> [9] https://lore.kernel.org/u-boot/e7b7b905-4a6c-4342-b1a5-0ad32a5837cf@gmx.de/
> 
> Cc: stable@...r.kernel.org
> Reported-by: Heinrich Schuchardt <xypron.glpk@....de>
> Signed-off-by: Quentin Schulz <quentin.schulz@...rry.de>
> ---
> Note: I do not own any of the Rock Pi 4 variants so I cannot work on
> fixing the original issue report by Alex.
> ---
>  arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi
> index 046dbe3290178..fda7ea87e4efc 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi
> @@ -516,7 +516,7 @@ &i2s2 {
>  };
>  
>  &io_domains {
> -	audio-supply = <&vcca1v8_codec>;
> +	audio-supply = <&vcc_3v0>;

This revert/patch seem to be identical to the following patch from a
month ago:

https://lore.kernel.org/all/20251027005220.22298-1-naoki@radxa.com/

Regards,
Jonas

>  	bt656-supply = <&vcc_3v0>;
>  	gpio1830-supply = <&vcc_3v0>;
>  	sdmmc-supply = <&vcc_sdio>;
> 
> ---
> base-commit: 765e56e41a5af2d456ddda6cbd617b9d3295ab4e
> change-id: 20251127-rock-pi-4-io-domain-apio5-26bc2afa8224
> 
> Best regards,