linux-kernel - Re: [PATCH] remoteproc: st: Fix indexing of memory-regions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aShv8UtdOKcN0Pof@p14s>
Date: Thu, 27 Nov 2025 08:36:17 -0700
From: Mathieu Poirier <mathieu.poirier@...aro.org>
To: Bjorn Andersson <bjorn.andersson@....qualcomm.com>
Cc: Patrice Chotard <patrice.chotard@...s.st.com>,
	Bjorn Andersson <andersson@...nel.org>,
	"Rob Herring (Arm)" <robh@...nel.org>,
	Arnaud Pouliquen <arnaud.pouliquen@...s.st.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	linux-arm-msm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] remoteproc: st: Fix indexing of memory-regions

On Wed, Nov 26, 2025 at 12:17:59PM -0600, Bjorn Andersson wrote:
> The recent transition to use of_reserved_mem_region_to_resource()
> changes the while loop to a for loop, but the increment of the "index"
> variable was left behind at the end of the loop, as highlighted by the
> following error/warning:
> 
>   error: variable 'index' is incremented both in the loop header and in the loop body [-Werror,-Wfor-loop-analysis]
> 
> Drop the extra increment to avoid skipping over every other
> memory-region in the loop.
> 
> Fixes: 67a7bc7f0358 ("remoteproc: Use of_reserved_mem_region_* functions for "memory-region"")
> Signed-off-by: Bjorn Andersson <bjorn.andersson@....qualcomm.com>
> ---
>  drivers/remoteproc/st_remoteproc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/st_remoteproc.c b/drivers/remoteproc/st_remoteproc.c
> index 747bbe7f6f7c6be160f4f6a0202eb8df20dc5bc9..a07edf7217d21a3f08d26592e8a14814608507f8 100644
> --- a/drivers/remoteproc/st_remoteproc.c
> +++ b/drivers/remoteproc/st_remoteproc.c
> @@ -155,7 +155,6 @@ static int st_rproc_parse_fw(struct rproc *rproc, const struct firmware *fw)
>  			return -ENOMEM;
>  
>  		rproc_add_carveout(rproc, mem);
> -		index++;

Really good - applied.

Thanks,
Mathieu

>  	}
>  
>  	return rproc_elf_load_rsc_table(rproc, fw);
> 
> ---
> base-commit: 663d0d1af3faefe673cabf4b6b077149a87ad71f
> change-id: 20251126-st-remoteproc-double-index-29a2e40e74bb
> 
> Best regards,
> -- 
> Bjorn Andersson <bjorn.andersson@....qualcomm.com>
>