linux-kernel - Re: [PATCH net-next V4 06/14] devlink: Add parent dev to devlink API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3ec956ea1d0a1c6e56865b2ded6d83ed773ccd4d.camel@nvidia.com>
Date: Thu, 27 Nov 2025 19:18:15 +0000
From: Cosmin Ratiu <cratiu@...dia.com>
To: Tariq Toukan <tariqt@...dia.com>, "horms@...nel.org" <horms@...nel.org>
CC: "corbet@....net" <corbet@....net>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "donald.hunter@...il.com" <donald.hunter@...il.com>,
	"davem@...emloft.net" <davem@...emloft.net>, "leon@...nel.org"
	<leon@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>, "jiri@...nulli.us"
	<jiri@...nulli.us>, "pabeni@...hat.com" <pabeni@...hat.com>, Jiri Pirko
	<jiri@...dia.com>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	Carolina Jubran <cjubran@...dia.com>, Mark Bloch <mbloch@...dia.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "rdunlap@...radead.org"
	<rdunlap@...radead.org>, Saeed Mahameed <saeedm@...dia.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, Gal Pressman
	<gal@...dia.com>, Moshe Shemesh <moshe@...dia.com>
Subject: Re: [PATCH net-next V4 06/14] devlink: Add parent dev to devlink API

On Thu, 2025-11-27 at 15:28 +0000, Simon Horman wrote:
> On Tue, Nov 25, 2025 at 10:06:05PM +0200, Tariq Toukan wrote:
> >  net/devlink/netlink_gen.c                |  5 ++
> >  net/devlink/netlink_gen.h                |  8 +++
> 
> Hi,
> 
> I think that the updates to netlink_gen.[ch] belong in
> the following patch rather than this one.
> 
> You can observe this using
> 
> tools/net/ynl/ynl-regen.sh -f && git diff

Hi,

You are right, some of these changes belong to the next patch. We will
fix in the next submission.
But running ynl-regen.sh results in unbuildable code, due to missing
devlink_dl_parent_dev_nl_policy. It seems it is not added unless the
attribute is referenced in at least one attribute set.
Additionally, the devlink_nl_pre_doit_parent_dev_optional needs to be
manually added to netlink-gen.{h,c}, as it is not automatically
generated.

Cosmin.