linux-kernel - Re: [PATCH v2 0/2] scsi: ufs: Add crypto_keyslot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251127222429.GB2977@sol>
Date: Thu, 27 Nov 2025 14:24:29 -0800
From: Eric Biggers <ebiggers@...nel.org>
To: "zheng.gong" <zheng.gong@...sung.com>
Cc: linux-scsi@...r.kernel.org, avri.altman@....com, bvanassche@....org,
	quic_cang@...cinc.com, alim.akhtar@...sung.com,
	martin.petersen@...cle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] scsi: ufs: Add crypto_keyslot_remap support

On Thu, Nov 27, 2025 at 03:06:57PM +0800, zheng.gong wrote:
> This patch series adds support for platform-specific crypto keyslot remapping
> in the UFS host driver, enabling secure inline encryption in multi-domain
> environments (e.g., VMs).
> 
> The first patch introduces a new variant operation:
>   ufs_hba_variant_ops::crypto_keyslot_remap
> which allows platforms to adjust the keyslot index at request submission time.
> 
> The second patch adds a test module (CONFIG_SCSI_UFS_CRYPTO_TEST) to
> demonstrate how the new hook is used — by applying a fixed offset to simulate
> domain-specific keyslot layout. This patch series is in response to feedback from Eric on the v1 submission,
> where he noted that the new callback needed to be used to make sense. Just a demonstration
> of the new callback is included in this patch series.

There has to be a real user, not just a useless example module.

Perhaps you intend for this functionality to be used in ufs-exynos.c?
But you haven't sent any corresponding patch.

- Eric