linux-kernel - RE: [PATCH 1/2] dt-bindings: usb: aspeed,usb-vhub: Add ast2700 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TY2PPF5CB9A1BE661637E3365B5ADEDC2BDF2DFA@TY2PPF5CB9A1BE6.apcprd06.prod.outlook.com>
Date: Thu, 27 Nov 2025 00:42:03 +0000
From: Ryan Chen <ryan_chen@...eedtech.com>
To: Conor Dooley <conor@...nel.org>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Rob Herring
	<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, Joel Stanley <joel@....id.au>, Andrew Jeffery
	<andrew@...econstruct.com.au>, Benjamin Herrenschmidt
	<benh@...nel.crashing.org>, Philipp Zabel <p.zabel@...gutronix.de>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/2] dt-bindings: usb: aspeed,usb-vhub: Add ast2700
 support

> Subject: Re: [PATCH 1/2] dt-bindings: usb: aspeed,usb-vhub: Add ast2700
> support
> 
> On Wed, Nov 26, 2025 at 04:26:30PM +0800, Ryan Chen wrote:
> > Add the "aspeed,ast2700-usb-vhub" compatible. The ast2700 vhub
> > controller requires an reset, so make the "resets" property mandatory
> > for this compatible to reflect the hardware requirement.
> >
> > Signed-off-by: Ryan Chen <ryan_chen@...eedtech.com>
> > ---
> >  Documentation/devicetree/bindings/usb/aspeed,usb-vhub.yaml | 14
> > ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/usb/aspeed,usb-vhub.yaml
> > b/Documentation/devicetree/bindings/usb/aspeed,usb-vhub.yaml
> > index 7f22f9c031b2..c9ebb6e004d1 100644
> > --- a/Documentation/devicetree/bindings/usb/aspeed,usb-vhub.yaml
> > +++ b/Documentation/devicetree/bindings/usb/aspeed,usb-vhub.yaml
> > @@ -26,6 +26,7 @@ properties:
> >        - aspeed,ast2400-usb-vhub
> >        - aspeed,ast2500-usb-vhub
> >        - aspeed,ast2600-usb-vhub
> > +      - aspeed,ast2700-usb-vhub
> >
> >    reg:
> >      maxItems: 1
> > @@ -33,6 +34,9 @@ properties:
> >    clocks:
> >      maxItems: 1
> >
> > +  resets:
> > +    maxItems: 1
> > +
> >    interrupts:
> >      maxItems: 1
> >
> > @@ -107,6 +111,16 @@ required:
> >    - aspeed,vhub-downstream-ports
> >    - aspeed,vhub-generic-endpoints
> >
> > +if:
> > +  properties:
> > +    compatible:
> > +      contains:
> > +        const: aspeed,ast2700-usb-vhub
> > +
> > +then:
> > +  required:
> > +    - resets
> 
> Do other aspeed platforms have resets? If not, please add an else here to block
> its use on other platforms.

I will update to following. 

   if:
      properties:
        compatible:
          contains:
            const: aspeed,ast2700-usb-vhub
    then:
      required:
        - resets

    else:
      properties:
        resets: false

Thanks your review.
> 
> > +
> >  additionalProperties: false
> >
> >  examples:
> >
> > --
> > 2.34.1
> >