linux-kernel - RE: [PATCH v1 1/1] spi: nxp-fspi: Propagate fwnode in ACPI case as well

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DU0PR04MB9496A87FC85F20D9649D35D190DFA@DU0PR04MB9496.eurprd04.prod.outlook.com>
Date: Thu, 27 Nov 2025 03:41:37 +0000
From: Bough Chen <haibo.chen@....com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Mark Brown
	<broonie@...nel.org>, "linux-spi@...r.kernel.org"
	<linux-spi@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: Han Xu <han.xu@....com>, Yogesh Gaur <yogeshgaur.83@...il.com>
Subject: RE: [PATCH v1 1/1] spi: nxp-fspi: Propagate fwnode in ACPI case as
 well

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Sent: 2025年11月27日 4:25
> To: Mark Brown <broonie@...nel.org>; Bough Chen <haibo.chen@....com>;
> linux-spi@...r.kernel.org; imx@...ts.linux.dev; linux-kernel@...r.kernel.org
> Cc: Han Xu <han.xu@....com>; Yogesh Gaur <yogeshgaur.83@...il.com>;
> Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Subject: [PATCH v1 1/1] spi: nxp-fspi: Propagate fwnode in ACPI case as well
> 
> Propagate fwnode of the ACPI device to the SPI controller Linux device.
> Currently only OF case propagates fwnode to the controller.
> 
> While at it, replace several calls to dev_fwnode() with a single one cached in a
> local variable, and unify checks for fwnode type by using
> is_*_node() APIs.

Reviewed-by: Haibo Chen <haibo.chen@....com>

Thanks
Haibo Chen
> 
> Fixes: 55ab8487e01d ("spi: spi-nxp-fspi: Add ACPI support")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/spi/spi-nxp-fspi.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c index
> b6c79e50d842..50a7e4916a60 100644
> --- a/drivers/spi/spi-nxp-fspi.c
> +++ b/drivers/spi/spi-nxp-fspi.c
> @@ -1287,7 +1287,7 @@ static int nxp_fspi_probe(struct platform_device
> *pdev)  {
>  	struct spi_controller *ctlr;
>  	struct device *dev = &pdev->dev;
> -	struct device_node *np = dev->of_node;
> +	struct fwnode_handle *fwnode = dev_fwnode(dev);
>  	struct resource *res;
>  	struct nxp_fspi *f;
>  	int ret, irq;
> @@ -1309,7 +1309,7 @@ static int nxp_fspi_probe(struct platform_device
> *pdev)
>  	platform_set_drvdata(pdev, f);
> 
>  	/* find the resources - configuration register address space */
> -	if (is_acpi_node(dev_fwnode(f->dev)))
> +	if (is_acpi_node(fwnode))
>  		f->iobase = devm_platform_ioremap_resource(pdev, 0);
>  	else
>  		f->iobase = devm_platform_ioremap_resource_byname(pdev,
> "fspi_base"); @@ -1317,7 +1317,7 @@ static int nxp_fspi_probe(struct
> platform_device *pdev)
>  		return PTR_ERR(f->iobase);
> 
>  	/* find the resources - controller memory mapped space */
> -	if (is_acpi_node(dev_fwnode(f->dev)))
> +	if (is_acpi_node(fwnode))
>  		res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
>  	else
>  		res = platform_get_resource_byname(pdev,
> @@ -1330,7 +1330,7 @@ static int nxp_fspi_probe(struct platform_device
> *pdev)
>  	f->memmap_phy_size = resource_size(res);
> 
>  	/* find the clocks */
> -	if (dev_of_node(&pdev->dev)) {
> +	if (is_of_node(fwnode)) {
>  		f->clk_en = devm_clk_get(dev, "fspi_en");
>  		if (IS_ERR(f->clk_en))
>  			return PTR_ERR(f->clk_en);
> @@ -1383,7 +1383,7 @@ static int nxp_fspi_probe(struct platform_device
> *pdev)
>  	else
>  		ctlr->mem_caps = &nxp_fspi_mem_caps;
> 
> -	ctlr->dev.of_node = np;
> +	device_set_node(&ctlr->dev, fwnode);
> 
>  	ret = devm_add_action_or_reset(dev, nxp_fspi_cleanup, f);
>  	if (ret)
> --
> 2.50.1