linux-kernel - Re: [PATCH v12 1/3] dt-bindings: i2c: Add CP2112 HID USB to SMBus Bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251127-liberal-onyx-shark-eaeab6@kuoka>
Date: Thu, 27 Nov 2025 08:24:15 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Danny Kaehn <danny.kaehn@...xus.com>
Cc: Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Benjamin Tissoires <bentiss@...nel.org>, 
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Andi Shyti <andi.shyti@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Jiri Kosina <jikos@...nel.org>, devicetree@...r.kernel.org, 
	linux-input@...r.kernel.org, Dmitry Torokhov <dmitry.torokhov@...il.com>, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, Ethan Twardy <ethan.twardy@...xus.com>, 
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, Leo Huang <leohu@...dia.com>, 
	Arun D Patil <arundp@...dia.com>, Willie Thai <wthai@...dia.com>, 
	Ting-Kai Chen <tingkaic@...dia.com>
Subject: Re: [PATCH v12 1/3] dt-bindings: i2c: Add CP2112 HID USB to SMBus
 Bridge

On Wed, Nov 26, 2025 at 11:05:24AM -0600, Danny Kaehn wrote:
> +  i2c:
> +    description: The SMBus/I2C controller node for the CP2112
> +    $ref: /schemas/i2c/i2c-controller.yaml#
> +    unevaluatedProperties: false
> +
> +    properties:
> +      sda-gpios:
> +        maxItems: 1
> +
> +      scl-gpios:
> +        maxItems: 1

Neither scl nor sda-gpios are needed, they are allowed by i2c-controller
schema, so drop.

> +
> +      clock-frequency:
> +        minimum: 10000
> +        default: 100000
> +        maximum: 400000
> +
> +patternProperties:
> +  "-hog(-[0-9]+)?$":
> +    type: object
> +
> +    required:
> +      - gpio-hog
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    usb {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      cp2112: device@1 {
> +        compatible = "usb10c4,ea90";
> +        reg = <1>;
> +
> +        gpio-controller;
> +        interrupt-controller;
> +        #interrupt-cells = <2>;
> +        #gpio-cells = <2>;
> +        gpio-line-names = "CP2112_SDA", "CP2112_SCL", "TEST2",
> +          "TEST3","TEST4", "TEST5", "TEST6";

Please align the next line with opening ". See also DTS coding style.

> +
> +        fan-rst-hog {
> +            gpio-hog;
> +            gpios = <7 GPIO_ACTIVE_HIGH>;
> +            output-high;
> +            line-name = "FAN_RST";
> +        };
> +
> +        i2c {
> +          #address-cells = <1>;

Messed indentation, stick to one, preferred is 4 spaces for the example.

> +          #size-cells = <0>;
> +          sda-gpios = <&cp2112 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> +          scl-gpios = <&cp2112 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> +
> +          temp@48 {
> +            compatible = "national,lm75";
> +            reg = <0x48>;
> +          };
> +        };
> +

Drop blank line

> +      };
> +    };
> 
> -- 
> 2.25.1
>