linux-kernel - Re: [PATCH 1/3] dt-bindings: mtd: cdns,hp-nfc: Add dma-coherent property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251127-logical-gerbil-of-destiny-bd6d4f@kuoka>
Date: Thu, 27 Nov 2025 08:48:05 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Khairul Anuar Romli <khairul.anuar.romli@...era.com>
Cc: Dinh Nguyen <dinguyen@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>, Vinod Koul <vkoul@...nel.org>, 
	Miquel Raynal <miquel.raynal@...tlin.com>, Richard Weinberger <richard@....at>, 
	Vignesh Raghavendra <vigneshr@...com>, Niravkumar L Rabara <niravkumar.l.rabara@...el.com>, 
	dmaengine@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-mtd@...ts.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: mtd: cdns,hp-nfc: Add dma-coherent
 property

On Wed, Nov 26, 2025 at 04:06:22PM +0800, Khairul Anuar Romli wrote:
> The Cadence HP NAND Flash Controller on Agilex5 device performs DMA
> transactions through a coherent interconnect. dma-coherent property
> presents in device tree will allow the kernel’s DMA subsystem
> controller’s to performs DMA transaction in dma coherent mode.

Last sentence is redundant. You say basically "dma-coherent means
dma coherent". Write informative commit msgs, so something which is not
obvious, e.g. why this is dma coherent NOW but wasn't before?

Best regards,
Krzysztof