linux-kernel - Re: [PATCH 1/2] phy: rockchip: inno-usb2: fix disconnection in gadget mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DEJD8DJZFNZO.11B1UBXJBN7MO@bootlin.com>
Date: Thu, 27 Nov 2025 10:22:18 +0100
From: "Luca Ceresoli" <luca.ceresoli@...tlin.com>
To: Théo Lebrun <theo.lebrun@...tlin.com>, "Vinod Koul"
 <vkoul@...nel.org>, "Kishon Vijay Abraham I" <kishon@...nel.org>, "Heiko
 Stuebner" <heiko@...ech.de>, "William Wu" <wulf@...k-chips.com>
Cc: "Kever Yang" <kever.yang@...k-chips.com>, "Minas Harutyunyan"
 <Minas.Harutyunyan@...opsys.com>, "Alan Stern" <stern@...land.harvard.edu>,
 "Louis Chauvet" <louis.chauvet@...tlin.com>, Hervé Codina
 <herve.codina@...tlin.com>, "Thomas Petazzoni"
 <thomas.petazzoni@...tlin.com>, <linux-phy@...ts.infradead.org>,
 <linux-rockchip@...ts.infradead.org>, <linux-usb@...r.kernel.org>,
 <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] phy: rockchip: inno-usb2: fix disconnection in
 gadget mode

Hi Théo,

thanks for reviewing this series!

On Tue Nov 25, 2025 at 4:28 PM CET, Théo Lebrun wrote:
[...]
>> The problem was observed on a Radxa Rock Pi S board, which can only be
>> powered by the only USB-C connector. That connector is the only one usable
>
> "which can only be powered by the only USB-C connector"
> double "only" makes it a super exclusive connector!

Hehe, indeed! :-)

>> The code already checks for !rport->suspended, so add a guard for VBUS as
>> well to avoid a disconnection when a cable is connected.
>
> Your commit message was clear but I was missing one key point: what
> rport->suspended means. It isn't what I first thought. Instead it means
> phy is powered off. Naming is bad but unrelated to your series. Maybe
> add a comment to your commit message like the following?
>
>   The code already checks for !rport->suspended (PHY is powered on), ...

You are right. I have added a slightly longer text:

  The code already checks for !rport->suspended (which, somewhat
  counter-intuitively, means the PHY is powered on), ...

Still worth your Reviewed-by?

I fixed the other issues you have reported, for patch 2 as well.

I also added the Cc: stable@...r.kernel.org line, which I noticed being
missing.

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com