linux-kernel - Re: [PATCH v1 2/2] platform/x86: serial-multi-instantiate: Remove duplicate check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <71904f34-8f91-0443-00c0-318519840aca@linux.intel.com>
Date: Thu, 27 Nov 2025 11:54:32 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
cc: Baojun Xu <baojun.xu@...com>, linux-i2c@...r.kernel.org, 
    linux-acpi@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, 
    platform-driver-x86@...r.kernel.org, 
    Wolfram Sang <wsa+renesas@...g-engineering.com>, 
    Mika Westerberg <westeri@...nel.org>, Hans de Goede <hansg@...nel.org>
Subject: Re: [PATCH v1 2/2] platform/x86: serial-multi-instantiate: Remove
 duplicate check

On Tue, 25 Nov 2025, Andy Shevchenko wrote:

> Since i2c_acpi_client_count() stopped returning 0 and instead
> uses -ENOENT, remove the duplicated check in smi_i2c_probe().
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/platform/x86/serial-multi-instantiate.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/platform/x86/serial-multi-instantiate.c b/drivers/platform/x86/serial-multi-instantiate.c
> index db030b0f176a..3f6f5d51442c 100644
> --- a/drivers/platform/x86/serial-multi-instantiate.c
> +++ b/drivers/platform/x86/serial-multi-instantiate.c
> @@ -198,9 +198,6 @@ static int smi_i2c_probe(struct platform_device *pdev, struct smi *smi,
>  	ret = i2c_acpi_client_count(adev);
>  	if (ret < 0)
>  		return ret;
> -	if (!ret)
> -		return -ENOENT;
> -
>  	count = ret;
>  
>  	smi->i2c_devs = devm_kcalloc(dev, count, sizeof(*smi->i2c_devs), GFP_KERNEL);
> 

Acked-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
 i.