linux-kernel - Re: [PATCH] ocfs2: Replace deprecated strcpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <69786F67-0B00-4FDE-8789-E22EDDB96CB1@linux.dev>
Date: Thu, 27 Nov 2025 11:13:51 +0100
From: Thorsten Blum <thorsten.blum@...ux.dev>
To: Joseph Qi <joseph.qi@...ux.alibaba.com>
Cc: Mark Fasheh <mark@...heh.com>,
 Joel Becker <jlbec@...lplan.org>,
 ocfs2-devel@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ocfs2: Replace deprecated strcpy with strscpy

On 27. Nov 2025, at 02:13, Joseph Qi wrote:
> On 2025/11/26 19:44, Thorsten Blum wrote:
>> strcpy() has been deprecated [1] because it performs no bounds checking
>> on the destination buffer, which can lead to buffer overflows. Replace
>> it with the safer strscpy().  No functional changes.
>> 
>> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1]
>> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
>> ---
>> [...]
> 
> It seems that all 'include' above are not needed.

They might not be necessary for the code to compile, but I think it's
recommended to add the headers to make the relationship explicit.

Thanks,
Thorsten