linux-kernel - Re: [PATCH v4 2/2] dts: aspeed: Add a dts for the nvidia msx4 hpm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f1a18e7b8deb5987164b4506f8400dcad67a8862.camel@codeconstruct.com.au>
Date: Thu, 27 Nov 2025 10:39:22 +1030
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Marc Olberding <molberding@...dia.com>, Rob Herring <robh@...nel.org>, 
 Krzysztof Kozlowski
	 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Joel Stanley
	 <joel@....id.au>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] dts: aspeed: Add a dts for the nvidia msx4 hpm

Hi Marc,

On Mon, 2025-11-24 at 15:14 -0800, Marc Olberding wrote:
> Adds a dts for the nvidia mgx pcie switchboard reference
> platformi hpm. This is a dual socket granite rapids based platform.

I was looking to apply this, and set about tweaking the commit message
in the process, but the more I tweaked the more I felt I needed to
tweak. So rather than do all that myself, I'll ask that you work
through these requests :)

The things that I'd like addressed are:

1. The subject prefix needs to begin with "ARM: ", so:

   ARM: dts: aspeed: ...

2. I'd rather stick to formalised naming and capitalisation, so NVIDIA,
MSX4, and HPM, Granite Rapids etc

3. "Add a dts for" in the subject is a bit redundant, as we already
have "dts" in the prefix. We can trim that out:

   ARM: dts: aspeed: Add NVIDIA MSX4 HPM platform

4. "HPM" hasn't yet been expanded anywhere and it's still a mystery to
me. Can we unpack that in the commit message?

5. "Adds a dts for ..." in the commit message is self-evident from the
patch. Rather, can you please talk a bit more about the purpose of the
platform? I'd like to see discussion of its use cases and any
interesting points of design or implementation.

Cheers,

Andrew